Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2: update page #12799

Merged
merged 2 commits into from
May 18, 2024
Merged

d2: update page #12799

merged 2 commits into from
May 18, 2024

Conversation

kant
Copy link
Member

@kant kant commented May 17, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the page edit Changes to an existing page(s). label May 17, 2024
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, we already display the placeholder options for both the outputs at the current {{path/to/output_file.svg|path/to/output_file.[svg|png]}} example, so the current addition would make it redundant with the existing placeholder.


Edit. just now noticed #12742, will update my suggestion for it.

@kbdharun kbdharun dismissed their stale review May 17, 2024 15:58

Re-doing the review with updated suggestions (referring to the other PR)

@sebastiaanspeck sebastiaanspeck merged commit d80f835 into main May 18, 2024
8 checks passed
@sebastiaanspeck sebastiaanspeck deleted the kant-patch-8 branch May 18, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants