Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor, torify: add pages #12810

Merged
merged 1 commit into from
May 21, 2024
Merged

tor, torify: add pages #12810

merged 1 commit into from
May 21, 2024

Conversation

eshedruf
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented May 19, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label May 19, 2024
@tldr-bot

This comment was marked as outdated.

@spageektti spageektti changed the title tor: add page, torify: add page tor, torify: add pages May 19, 2024
@spageektti
Copy link
Member

Hello @eshedruf, thanks for your contribution to TLDR Pages! Can you please fix the error with trailing whitespace and sign the CLA?

pages/linux/tor.md Outdated Show resolved Hide resolved
@eshedruf
Copy link
Contributor Author

Hello @eshedruf, thanks for your contribution to TLDR Pages! Can you please fix the error with trailing whitespace and sign the CLA?

Ok, did it

pages/linux/torify.md Outdated Show resolved Hide resolved
pages/linux/torify.md Outdated Show resolved Hide resolved
pages/linux/tor.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to tldr and thanks for your contribution. I have some minor suggestions for this page.

pages/linux/tor.md Outdated Show resolved Hide resolved
pages/linux/torify.md Outdated Show resolved Hide resolved
pages/linux/torify.md Outdated Show resolved Hide resolved
pages/linux/torify.md Outdated Show resolved Hide resolved
@eshedruf
Copy link
Contributor Author

@spageektti @kbdharun your changes look good, I added them.

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pages almost LGTM, we could add more information links for additional information.

pages/linux/tor.md Show resolved Hide resolved
pages/linux/torify.md Show resolved Hide resolved

- Redirect output to a file:

`torify {{command}} > output.txt`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`torify {{command}} > output.txt`
`torify {{command}} > {{path/to/output}}`

IG we can convert this to a placeholder. Also, I have removed the extension as any extensions can be used.

@spageektti spageektti merged commit df15d66 into tldr-pages:main May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants