-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
textfields [2 of 3]: refactor to share logic/components; make composable UI #3051
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
packages/editor/src/lib/components/default-components/DefaultTextLabel.tsx
Outdated
Show resolved
Hide resolved
packages/editor/src/lib/components/default-components/DefaultTextLabel.tsx
Show resolved
Hide resolved
So my overall take on this is that i like it & it's a step in the right direction. Using component overrides for shapes isn't something that we've done before (and should def be a But! I don't think this is the ideal solution, or where we would land if we took a step back and looked at some of the wider context. these text changes are a small subset of a bigger problem, and one we hear from our community about again and again: customising our built-in shapes. we very regularly get requests that roughly look like "i want the interactions/structure of your shape, but i want to control rendering/styling myself, and maybe add some extra interactions on top". To me, your emoji stuff is a subset of that problem, but I'm not sure the solution here would generalise well to the wider issue - i don't think we would want to add component overrides for every bit of a shape. That said - I still think we should land this! It's 100% a step in the right direction and would give us a good place to iterate from. Although I do think this would be the perfect place to experiment with calling out a certain part of our API as experimental/unstable in docs. What do you think? |
This is the second of three textfield changes. This makes the textfields composable and refactors the hell out of them.
π΅ this is dangerous, I walk through textfields so watch your head rock π΅
Change Type
minor
β New featureRelease Notes