[experiment] Allow users to use system's appearance (dark / light) mode #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
MitjaBezensek
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
MitjaBezensek
had a problem deploying
to
deploy-staging
GitHub Actions
Error
MitjaBezensek
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
MitjaBezensek
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
MitjaBezensek
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
MitjaBezensek
changed the title
|
this is sick 🎸 |
|
From a UX perspective I'm in agreement, great feature! Adding @ds300 as a reviewer here just to be sure that the user preferences stuff is compatible. |
ds300
reviewed
Jun 3, 2024
Comment on lines
+51
to
+54
| case 'system': | ||
| return this.systemColorScheme.get() === 'dark' | ||
| default: | ||
| return this.inferDarkMode ? this.systemColorScheme.get() === 'dark' : false |
There was a problem hiding this comment.
as mentioned elsewhere, inferDarkMode will only be respected when colorScheme is undefined, but at the moment that can't happen without the sdk user explicitly setting it to undefined because our default user preferences sets it to 'light'
Co-authored-by: David Sheldrick <d.j.sheldrick@gmail.com>
MitjaBezensek
force-pushed
the
mitja/color-scheme
branch
from
24e4e52
to
5bcb803
Compare
MitjaBezensek
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
huppy-bot
bot
added
improvement
Yeah, nice catch. Updated with your recommendation and brought it up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the users to fully use the same colour scheme as their system. Allows the users to either: force dark colour scheme, force light colour scheme, or use the system one.
It's reactive to the system changes.
CleanShot.2024-05-06.at.17.28.27.mp4
Change Type
sdk— Changes the tldraw SDKdotcom— Changes the tldraw.com web appdocs— Changes to the documentation, examples, or templates.vs code— Changes to the vscode plugininternal— Does not affect user-facing stuffbugfix— Bug fixfeature— New featureimprovement— Improving existing featureschore— Updating dependencies, other boring stuffgalaxy brain— Architectural changestests— Changes to any test codetools— Changes to infrastructure, CI, internal scripts, debugging tools, etc.dunno— I don't knowTest Plan
Release Notes