Fix toolbar duplicate tools bug #3757
Conversation
…isible in toolbar
|
@ecan-dearx is attempting to deploy a commit to the tldraw Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey, thanks for your pull request! Before we can merge your PR, you will need to sign our Contributor License Agreement by posting a comment that reads:
|
|
I have read and agree to the Contributor License Agreement. |
engin-can
changed the title
|
Wow, how did I never notice this one? If we do remove a shape like this, I suppose that means we can restore one of the commented out tools, too. |
engin-can
had a problem deploying
to
deploy-staging
GitHub Actions
Failure
steveruizok
had a problem deploying
to
deploy-staging
GitHub Actions
Failure
|
@steveruizok i'm closing this one - it's superseded by #3779 |
Small side quest: This reworks the overflow toolbar css to rely on `nth-child` instead of putting together a long selector. This also address the minor issue/edge case raised in #3757 ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [x] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [ ] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [ ] `bugfix` — Bug fix - [ ] `feature` — New feature - [x] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Release Notes - Toolbar: cleanup overflow css rules. --------- Co-authored-by: Steve Ruiz <steveruizok@gmail.com>
|
Correction, this isn't a bug! And if we remove the duplicated tool then actually the menu gets too shuffled. Sorry @engin-can, closing this one! |
|
So are you saying you are keeping duplicate tools in this case? |
|
It's only an issue if there's one item in the overflow menu (and that's been resolved in this PR: #3779) The popout menu is meant to be stable and not shift as you select an item. (otherwise it would get confusing as items moved around) It may seem strange but it's the intended design. |
Solves issue where toolbar overflow menu has duplicate tools from main toolbar.
Before
After
Change Type
sdk— Changes the tldraw SDKdotcom— Changes the tldraw.com web appdocs— Changes to the documentation, examples, or templates.vs code— Changes to the vscode plugininternal— Does not affect user-facing stuffbugfix— Bug fixfeature— New featureimprovement— Improving existing featureschore— Updating dependencies, other boring stuffgalaxy brain— Architectural changestests— Changes to any test codetools— Changes to infrastructure, CI, internal scripts, debugging tools, etc.dunno— I don't know