Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google meet: add hardware whiteboard integration #3765

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

mimecuvalo
Copy link
Collaborator

pushing out my changes but this is a draft. we need to do look into this more:

  • we might need to reach out to Google support and request to be put on their "start a whiteboard" whitelist/partner list? it's actually pretty unclear how to get on that list. I don't see any permissions/API scopes that is meant to enable that πŸ€”
  • but maybe this is something that you @steveruizok as Google Workspace admin see on your end? let's look together when you get back.

I initially tried doing a bundle (using esbuild (and i tried parcel/rollup too)) but it didn't feel like the right path, and also it didn't work when loading it in the Apps Scripts.
So then I went the route of just doing an iframe and I think that feels much better. This means though that we do want our iframe protector to let through this usecase. But also, we could maybe just redirect always to a new room? I'm not sure yet.

The build script helps either build the prod or staging version depending on what you want.

Once we do find that the staging version works, then we'll go through the process of:

Change Type

  • sdk β€” Changes the tldraw SDK
  • dotcom β€” Changes the tldraw.com web app
  • docs β€” Changes to the documentation, examples, or templates.
  • vs code β€” Changes to the vscode plugin
  • internal β€” Does not affect user-facing stuff
  • bugfix β€” Bug fix
  • feature β€” New feature
  • improvement β€” Improving existing features
  • chore β€” Updating dependencies, other boring stuff
  • galaxy brain β€” Architectural changes
  • tests β€” Changes to any test code
  • tools β€” Changes to infrastructure, CI, internal scripts, debugging tools, etc.
  • dunno β€” I don't know

Release Notes

  • Google Meet: add hardware whiteboard integration

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
examples βœ… Ready (Inspect) Visit Preview May 20, 2024 1:53pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 1:53pm

@steveruizok
Copy link
Collaborator

Great progress! Would love to see steps to test this ourselves. Is there a sort of testflight for Google workspace apps if we wanted to launch it for our organization only, while we dial it in?

Once we have something ready, I'll do my song and dance to see if we can get it recommended. Most apps in this category use integrations as a way to generate users / accounts, which we don't really have at the moment, I would expect questions around "how does a user save this?" or "how can a user return to their board?". Maybe we could solve that with some UI, like an "email me a link" button.

@mimecuvalo mimecuvalo marked this pull request as ready for review May 20, 2024 13:42
@huppy-bot huppy-bot bot added feature internal Changes only affect the internal API labels May 20, 2024
@mimecuvalo
Copy link
Collaborator Author

discussed some things offline with @steveruizok. i'm pushing this out to staging so i can test out the app properly!

@steveruizok and yeah, like i said offline, it's less about getting it recommended - it's more that it has to be in a special category, it looks like. but i'm not quite sure. i think if we start the support ticket, it's more about getting it approved as a special-whiteboard app.

@mimecuvalo mimecuvalo added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 9ffd7f1 May 20, 2024
10 checks passed
@mimecuvalo mimecuvalo deleted the mime/google-app branch May 20, 2024 14:57
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2024
followup to #3765

### Change Type

<!-- ❗ Please select a 'Scope' label ❗️ -->

- [x] `sdk` β€” Changes the tldraw SDK
- [ ] `dotcom` β€” Changes the tldraw.com web app
- [ ] `docs` β€” Changes to the documentation, examples, or templates.
- [ ] `vs code` β€” Changes to the vscode plugin
- [ ] `internal` β€” Does not affect user-facing stuff

<!-- ❗ Please select a 'Type' label ❗️ -->

- [x] `bugfix` β€” Bug fix
- [ ] `feature` β€” New feature
- [ ] `improvement` β€” Improving existing features
- [ ] `chore` β€” Updating dependencies, other boring stuff
- [ ] `galaxy brain` β€” Architectural changes
- [ ] `tests` β€” Changes to any test code
- [ ] `tools` β€” Changes to infrastructure, CI, internal scripts,
debugging tools, etc.
- [ ] `dunno` β€” I don't know
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants