-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google meet: add hardware whiteboard integration #3765
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
1 Ignored Deployment
|
Great progress! Would love to see steps to test this ourselves. Is there a sort of testflight for Google workspace apps if we wanted to launch it for our organization only, while we dial it in? Once we have something ready, I'll do my song and dance to see if we can get it recommended. Most apps in this category use integrations as a way to generate users / accounts, which we don't really have at the moment, I would expect questions around "how does a user save this?" or "how can a user return to their board?". Maybe we could solve that with some UI, like an "email me a link" button. |
discussed some things offline with @steveruizok. i'm pushing this out to staging so i can test out the app properly! @steveruizok and yeah, like i said offline, it's less about getting it recommended - it's more that it has to be in a special category, it looks like. but i'm not quite sure. i think if we start the support ticket, it's more about getting it approved as a special-whiteboard app. |
followup to #3765 ### Change Type <!-- β Please select a 'Scope' label βοΈ --> - [x] `sdk` β Changes the tldraw SDK - [ ] `dotcom` β Changes the tldraw.com web app - [ ] `docs` β Changes to the documentation, examples, or templates. - [ ] `vs code` β Changes to the vscode plugin - [ ] `internal` β Does not affect user-facing stuff <!-- β Please select a 'Type' label βοΈ --> - [x] `bugfix` β Bug fix - [ ] `feature` β New feature - [ ] `improvement` β Improving existing features - [ ] `chore` β Updating dependencies, other boring stuff - [ ] `galaxy brain` β Architectural changes - [ ] `tests` β Changes to any test code - [ ] `tools` β Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` β I don't know
pushing out my changes but this is a draft. we need to do look into this more:
I initially tried doing a bundle (using esbuild (and i tried parcel/rollup too)) but it didn't feel like the right path, and also it didn't work when loading it in the Apps Scripts.
So then I went the route of just doing an iframe and I think that feels much better. This means though that we do want our iframe protector to let through this usecase. But also, we could maybe just redirect always to a new room? I'm not sure yet.
The build script helps either build the prod or staging version depending on what you want.
Once we do find that the staging version works, then we'll go through the process of:
Change Type
sdk
β Changes the tldraw SDKdotcom
β Changes the tldraw.com web appdocs
β Changes to the documentation, examples, or templates.vs code
β Changes to the vscode plugininternal
β Does not affect user-facing stuffbugfix
β Bug fixfeature
β New featureimprovement
β Improving existing featureschore
β Updating dependencies, other boring stuffgalaxy brain
β Architectural changestests
β Changes to any test codetools
β Changes to infrastructure, CI, internal scripts, debugging tools, etc.dunno
β I don't knowRelease Notes