Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect GCP credentials in encoded JSON #2865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Detect GCP credentials in encoded JSON #2865

wants to merge 1 commit into from

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented May 18, 2024 •
edited

Description:

This fixes #2864.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner May 18, 2024 19:20
rgmz
rgmz commented May 18, 2024
View reviewed changes
pkg/detectors/gcp/gcp.go
continue
}
if credentials != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the code to google.CredentialsFromJSON and it doesn't seem possible for credentials to be nil if err is nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCP Detector fails to detect encoded JSON
1 participant
@rgmz