keep deploying binary of app #705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tw93 Hi, could you merge this pr. I tested ok locally.
|
|
@liudonghua123 Thanks for the pr, here's a reference to the comment above, in addition to the hard work of merging directly into the dev branch, not into the master branch |
|
I see, I recreated the pr which trying to merge into dev branch. |
|
@liudonghua123 ok，Code modification and optimization also go together～～ |
@tw93 hi, i have updated the pr. However, it should working even I have not rebased the pr branch since no conflicts around the modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continue work of #616.