Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push instead of single buds #1179

Merged
merged 1 commit into from May 14, 2024
Merged

Push instead of single buds #1179

merged 1 commit into from May 14, 2024

Conversation

enescakir
Copy link
Member

When we bud a prog, we need to implement an additional label to wait it. However, when we bud a single prog, we can achieve the same functionality with pushing. Budding has the power to run multiple concurrent progs.

Net -91 lines 馃敟

@enescakir enescakir requested a review from a team February 3, 2024 23:31
@enescakir enescakir self-assigned this Feb 3, 2024
@enescakir enescakir changed the title Push instead of a single buds Push instead of single buds Feb 3, 2024
Copy link
Collaborator

@fdr fdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's hope for "push" after all. Would it be further streamlined if we changed "push"'s style to use continuations rather than the retval check? (cc: @byucesoy )

@enescakir
Copy link
Member Author

I have a branch for continues push 馃榾 Not created a PR yet. I'm finishing tests for it

@fdr
Copy link
Collaborator

fdr commented Feb 6, 2024

I have a branch for continues push 馃榾 Not created a PR yet. I'm finishing tests for it

馃く

@enescakir
Copy link
Member Author

It's not yet complete, but welcome to your feedbacks

#1193

When we bud a prog, we need to implement an additional label to wait it.
However, when we bud a single prog, we can achieve the same
functionality with pushing. Budding has the power to run multiple
concurrent progs.
@enescakir enescakir merged commit 41c57da into main May 14, 2024
7 checks passed
@enescakir enescakir deleted the push-instead-bud branch May 14, 2024 06:59
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants