Download custom images with fixed version #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
force-pushed
the
pykello/image_versioning
branch
3 times, most recently
from
ad4983e
to
ef8654f
Compare
enescakir
force-pushed
the
custom-image-version
branch
from
23e2e9a
to
51cc883
Compare
pykello
force-pushed
the
pykello/image_versioning
branch
2 times, most recently
from
f78b995
to
c8f4f5b
Compare
pykello
approved these changes
May 9, 2024
pykello
force-pushed
the
pykello/image_versioning
branch
2 times, most recently
from
6b43e9a
to
522340d
Compare
enescakir
force-pushed
the
custom-image-version
branch
2 times, most recently
from
5d09b08
to
02dcd6f
Compare
pykello
reviewed
May 13, 2024
byucesoy
approved these changes
May 13, 2024
When we download a custom image without specifying a version, defaults to the latest one, making it difficult to identify which version is in use on the host. Moreover, when we release a new version of an image, we don't immediately want to download the latest version. Instead, we prefer to test the new version before deploying it on the some hosts first. Using a fixed version also simplifies the verification of SHA256 checksums.
enescakir
force-pushed
the
custom-image-version
branch
from
02dcd6f
to
4cf4570
Compare
pykello
approved these changes
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download custom images with fixed version
When we download a custom image without specifying a version, defaults to the latest one, making it difficult to identify which version is in use on the host.
Moreover, when we release a new version of an image, we don't immediately want to download the latest version. Instead, we prefer to test the new version before deploying it on the some hosts first.
Using a fixed version also simplifies the verification of SHA256 checksums.
Add SHA256 checksums for custom images