Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade lowlight to 3.1.0 and update demo (CodeBlockLowlight) #5036

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

RakeshPotnuru
Copy link

Please describe your changes

  • Upgraded lowlight to 3.1.0
  • Updated demo, example, experiment for CodeBlockLowlight.

How did you accomplish your changes

By reading lowlight docs.

How have you tested your changes

Yes, tested. The build is successful.

How can we verify your changes

Read lowlight v3 Changelog.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

#4456

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit cfd180e
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66112ef4f68ec400081c2e68
😎 Deploy Preview https://deploy-preview-5036--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch changed the base branch from develop to main April 6, 2024 11:17
@bdbch bdbch changed the base branch from main to develop April 6, 2024 11:17
@bdbch
Copy link
Contributor

bdbch commented Apr 6, 2024

It seems like this PR is still based of on develop if I'm right? That means there are commits in that branch that we can't easily merge into main as we want to test them further (and I think updating lowlight to a new version would fit into a general minor update).

@RakeshPotnuru
Copy link
Author

Yes, that's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage open
Development

Successfully merging this pull request may close these issues.

None yet

3 participants