lib/posix-fdio: Allow owner/group == -1 for fchown #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support in fchown for the owner or group to be passed as -1, in which case that particular field is left unchanged. This mimimcs the behavior of Linux. Signed-off-by: Andrei Tatar <andrei@unikraft.io>
github-actions
bot
added
area/lib
razvand
requested review from
RaduNichita,
StefanJum and
Alex-deVis
and removed request for
a team
RaduNichita
approved these changes
May 27, 2024
There was a problem hiding this comment.
Looks good to me, thanks @andreittr !
Reviewed-by: Radu Nichita radunichita99@gmail.com
Alex-deVis
approved these changes
May 29, 2024
There was a problem hiding this comment.
Looks good!
Approved-by: Alex Apostolescu alexx.apostolescu@gmail.com
razvand
approved these changes
May 29, 2024
unikraft-bot
pushed a commit
that referenced
this pull request
May 29, 2024
This change adds support in fchown for the owner or group to be passed as -1, in which case that particular field is left unchanged. This mimimcs the behavior of Linux. Signed-off-by: Andrei Tatar <andrei@unikraft.io> Reviewed-by: Radu Nichita <radunichita99@gmail.com> Approved-by: Razvan Deaconescu <razvand@unikraft.io> GitHub-Closes: #1416
unikraft-bot
added
ci/merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds support in fchown for the owner or group to be passed as -1, in which case that particular field is left unchanged. This mimimcs the behavior of Linux.
Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Base target
x86_64or N/A]kvm,xenor N/A]app-python3or N/A]Additional configuration
N/A