New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write valid pieces received directly to file #13

Open

Panko2128 wants to merge 1 commit into veggiedefender:master from Panko2128:master

Panko2128 commented Dec 16, 2023

Keeping all pieces in a buffer may lead to memory issues for larger files, so the obvious fix is just reading the pieces into the file. This may

Files changed:
p2p.go

Download now takes in a filepath, and returns nil upon success
when a worker submits work to the results channel, the offset is calculated via piece index and written to the file

torrentfile.go

DownloadToFile just calls download, so it is actually not that necessary anymore


          changed pieces read into a buffer to writing to file as pieces were r…

e3a4420

…eceived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment