Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EDK2 build script for improved clarity and efficiency #2668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsvenbla
Copy link

@tsvenbla tsvenbla commented Dec 7, 2023

Refactor EDK2 build script for improved clarity and efficiency

  • Implement a case statement for setting architecture and postfix based on the input argument, enhancing readability and scalability.
  • Add a directory change check to exit the script if the cd command to the EDK2 source directory fails, improving robustness.
  • Consolidate file removal commands into a single line for each set of related files, simplifying the script structure.
  • Streamline the build commands with a conditional segment specifically for the AARCH64 architecture, making the script more concise.
  • Enhance the success check logic by verifying the existence of all expected output files before declaring success.

Note that I did not test this change, so merge after testing only.

Refactor EDK2 build script for improved clarity and efficiency

- Implement a case statement for setting architecture and postfix based on the input argument, enhancing readability and scalability.
- Add a directory change check to exit the script if the `cd` command to the EDK2 source directory fails, improving robustness.
- Consolidate file removal commands into a single line for each set of related files, simplifying the script structure.
- Streamline the build commands with a conditional segment specifically for the AARCH64 architecture, making the script more concise.
- Enhance the success check logic by verifying the existence of all expected output files before declaring success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant