Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get-params for rsc #65922

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Implement get-params for rsc #65922

wants to merge 1 commit into from

Conversation

vordgi
Copy link
Contributor

@vordgi vordgi commented May 18, 2024

What?

Just wanna leave a PR here that the technical basis for obtaining params in server components already exist.

Very basic implementation, without tests and errors. If you know about problems and risks that I don't know - please tell me, perhaps I will be able to deal with their elaboration and find a solution that suits you. After I will write all the tests and necessary logic.

Fixes #58862

@ijjk
Copy link
Member

ijjk commented May 18, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4cf2dbb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented May 18, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4cf2dbb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@joulev
Copy link
Contributor

joulev commented May 26, 2024

It appears you have to disable the router cache completely for this to work, and it only works in prod mode:

/**
 * @type {import('next').NextConfig}
 */
module.exports = {
  experimental: {
    staleTimes: { static: 0, dynamic: 0 },
  },
};

But the fact that this even works is amazing. I don't know the internals but, purely from the concept of partial rendering, this shouldn't even be possible, yet it actually works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants