Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vercel): handle vercel previews #325

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

omercnet
Copy link

get the hostname from searchParams so it works with vercel previews

a more robust solution would be to handle all the places where the site url is generated and fix that too

fixes #294

get the hostname from searchParams so it works with vercel previews
@vercel
Copy link

vercel bot commented Sep 27, 2023

@omercnet is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@lukasburns
Copy link

lukasburns commented Oct 15, 2023

Hi, thanks for this insight,
In DEV or PREVIEW mode when I press for examplle a <Link href='/route'>
the host does not stay, so the middleware adds de "app" host instead.
How would you go about maintaining the host name when routing through the app?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch preview
2 participants