Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postgres fragment tagged literal #395

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add postgres fragment tagged literal #395

wants to merge 4 commits into from
+116 −6

Conversation

jonasb
Copy link

@jonasb jonasb commented Sep 19, 2023

Add a fragment tagged literal in addition to the existing sql tagged literal. fragment creates a QueryFragment, that can be included in an sql tagged literal.

Example usage:

const sharedValues = fragment`${123}, ${'admin'}`;
await sql`INSERT INTO users (id, credits, role) VALUES (1, ${sharedValues}), (2, ${sharedValues})`;

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023 •
edited

⚠️ No Changeset found

Latest commit: 79a201e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 19, 2023

@jonasb is attempting to deploy a commit to the Curated Tests Team on Vercel.

A member of the Team first needs to authorize it.

orca-security-us[bot]
orca-security-us bot reviewed Sep 19, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@jonasb
Copy link
Author

jonasb commented Sep 19, 2023

This PR is addressing similar issues as #126, but without allowing unsafe SQL.

@jonasb jonasb mentioned this pull request Oct 4, 2023
Open
@jonasb
Copy link
Author

jonasb commented Nov 6, 2023

Missed that I forgot to run prettier

@jonasb
feat(postgres): Support fragment tagged literal
5943b34 
The new fragment tagged literals can be used to create fragments that
can be included in sql tagged literals.
@jonasb
feat(postgres): Remove duplicated values to sql tagged literal
264f6ec 
When using a fragment`` more than once, the same values would be
included multiple times in the resulting query. Now each uniqe value is
only passed along once.
@jonasb
chore(postgres): Refactor sqlTemplate
7e5686b
@jonasb
feat(postgres): Support nested sql fragments
79a201e
@jonasb
Copy link
Author

jonasb commented Nov 7, 2023

@vvo Could you please take a look again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonasb