Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kv): enable auto pipelining by default #680

Merged
merged 5 commits into from
May 27, 2024

Conversation

vvo
Copy link
Member

@vvo vvo commented May 17, 2024

We're making this a major release for safety but we believe
most applications can upgrade from 1.0.1 to 2 without any changes.
Auto pipelining should work by default and improve performance.

BREAKING CHANGE: Auto pipelining is on by default now, see
https://upstash.com/docs/oss/sdks/ts/redis/pipelining/auto-pipeline. This
brings performance benefits to any code making multiple redis commands
simultaneously.

If you detect bugs because of this, please open them at
https://github.com/vercel/storage/issues.

You can disable this new behavior with:

import { createClient } from '@vercel/kv';

const kv = createClient({
  url: ..,
  token: ..,
  enableAutoPipelining: false
});

vvo added 2 commits May 17, 2024 15:28
BREAKING CHANGE: auto pipelining is on by default now, see
https://upstash.com/docs/oss/sdks/ts/redis/pipelining/auto-pipeline. This
brings performance benefits to any code making multiple redis commands
simultaneously.

If you detect bugs because of this, please open them at
https://github.com/vercel/storage/issues.

You can disable this new behavior with:
```js
import { createClient } from '@vercel/kv';

const kv = createClient({
  url: ..,
  token: ..,
  enableAutoPipelining: false
});
```
@vvo vvo requested review from cramforce and luismeyer May 17, 2024 13:32
@vvo vvo self-assigned this May 17, 2024
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vercel-storage-next-integration-test-suite ✅ Ready (Inspect) Visit Preview May 27, 2024 2:42pm

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: c16c2db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vercel/kv Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented May 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@upstash/redis@1.25.2

View full report↗︎

@CahidArda
Copy link

CahidArda commented May 22, 2024

Great to see auto pipelining in vercel storage!

We have a patch for auto-pipelining JSON commands in upstash-redis, we will release version 1.31.3 soon.

@CahidArda
Copy link

CahidArda commented May 23, 2024

@vvo
Copy link
Member Author

vvo commented May 27, 2024

@CahidArda updated 👍

@vvo vvo merged commit d02e08a into main May 27, 2024
12 checks passed
@vvo vvo deleted the feat/kv/activate-auto-pipelining-by-default branch May 27, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants