fix: log spacing depending on the FORMAT and COLORS options #4631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4630
Previously, when colors were enabled, the log message always had a single space padded to the left, otherwise a single space was always padded to the right. This padding of the full log message seemed to be entirely unnecessary. Also, there was no explicit space set to appear between the timestamp and the log message, although when colors were enabled, the padding mentioned above would include a space, but only in that case.
Now, there's always a space between the timestamp and the log message, and there are no unnecessary spaces inserted at the beginning or end of the log message. I tested locally with all four combinations of
format: pretty
,format: pretty-timestamped
,colors: false
, andcolors: true
, and I believe the spacing now appears correct.format: pretty
withcolors: false
orcolors: true
:format: pretty-timestamped
withcolors: false
orcolors: true
: