Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARTO: QuadbinHeatmapTileLayer docs #8909

Merged
merged 8 commits into from
May 21, 2024
Merged

Conversation

felixpalmer
Copy link
Collaborator

Documentation update for #8703

docs/api-reference/carto/quadbin-heatmap-tile-layer.md Outdated Show resolved Hide resolved

Controls how weight values are mapped to the `colorRange`, as an array of two numbers [`minValue`, `maxValue`].

When `colorDomain` is specified, a pixel with `minValue` is assigned the first color in `colorRange`, a pixel with `maxValue` is assigned the last color in `colorRange`, and any value in between is linearly interpolated. Pixels with weight less than `minValue` gradually fade out by reducing alpha, until 100% transparency representing `0`. Pixels with weight more than `maxValue` are capped to the last color in `colorRange`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and any value in between is linearly interpolated.

Perhaps just "any value in between is interpolated"? I'm probably overthinking it, but I could see this implying interpolation in a linear color space, which the layer currently does not do.

... until 100% transparency representing 0

Given a signed colorDomain like [-100, 100], I wouldn't be sure how to interpret this... if full transparency represents zero, perhaps something should be said about interpolation between the domain minimum and zero?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link

coveralls commented May 21, 2024

Coverage Status

coverage: 89.841% (+0.001%) from 89.84%
when pulling 2c14323 on felix/quadbin-heatmap-docs
into 995cf59 on master.

@felixpalmer felixpalmer merged commit eebcdd4 into master May 21, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/quadbin-heatmap-docs branch May 21, 2024 07:42
donmccurdy pushed a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants