-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uptime RPC to use in PRS #15947
Add Uptime RPC to use in PRS #15947
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <manan@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15947 +/- ##
==========================================
+ Coverage 68.41% 68.42% +0.01%
==========================================
Files 1562 1562
Lines 197056 197105 +49
==========================================
+ Hits 134807 134864 +57
+ Misses 62249 62241 -8 ☔ View full report in Codecov by Sentry. |
Superseded by #16022 since we can directly read the |
Description
This PR starts the work for #15946.
In order to use the replica which has the highest uptime, we first need the ability to select the uptime. This PR adds a new RPC to the tablet manager client interface for this.
In the next release, when this RPC is available on all the vttablets, we can use this RPC instead of
PrimaryStatus
to check for the availability of all the replicas in PRS. Currently we are throwing away the results ofPrimaryStatus
. Instead we can callUptime
and even use the results for better choosing the primary candidate.Related Issue(s)
Checklist
Deployment Notes