Update operator.yaml and add schedule backup example
#15969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
frouioui
added
Type: Enhancement
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
commented
May 17, 2024
| @@ -1,4 +1,3 @@ | |||
| --- | |||
| apiVersion: apiextensions.k8s.io/v1 | |||
There was a problem hiding this comment.
The file is a copy of the output we get when generating the operator.yaml file in the vitess-operator repository, on top of the PR planetscale/vitess-operator#553
GuptaManan100
approved these changes
May 20, 2024
Comment on lines
-6158
to
-6173
| --- | ||
| apiVersion: scheduling.k8s.io/v1 | ||
| description: The vitess-operator control plane. | ||
| globalDefault: false | ||
| kind: PriorityClass | ||
| metadata: | ||
| name: vitess-operator-control-plane | ||
| value: 5000 | ||
| --- | ||
| apiVersion: scheduling.k8s.io/v1 | ||
| description: Vitess components (vttablet, vtgate, vtctld, etcd) | ||
| globalDefault: false | ||
| kind: PriorityClass | ||
| metadata: | ||
| name: vitess | ||
| value: 1000 |
There was a problem hiding this comment.
I don't think we want to remove this.
There was a problem hiding this comment.
We are not removing this block, the tool moved it a bit earlier in the file. I have used the raw output of kustomize which I think is what we should do from now on to avoid any conflict or unnecessary changes in the future.
deepthi
approved these changes
May 31, 2024
|
Added "Do not merge" because the operator PR needs to be merged first, then this one, and then the website PR. |
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15969 +/- ##
==========================================
- Coverage 68.45% 68.22% -0.23%
==========================================
Files 1562 1541 -21
Lines 197057 197254 +197
==========================================
- Hits 134891 134585 -306
- Misses 62166 62669 +503 ☔ View full report in Codecov by Sentry. |
|
DCO is working wrong right now, manually verified signoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request adds one more step to the operator example: schedule backup. It comes at the very end of the guide, after
Resharding. For this a new401_file is added.The
operator.yamlfile is also modified to reflect the changes brought by planetscale/vitess-operator#553.Related Issue(s)