checker: turn warnings for private fields into errors (AFTER 2024-05-31) #21296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
force-pushed
the
checker/private-fields-errors
branch
4 times, most recently
from
7b98dc6
to
8805dfc
Compare
spytheman
approved these changes
Apr 17, 2024
spytheman
changed the title
ttytm
force-pushed
the
checker/private-fields-errors
branch
from
8805dfc
to
ae2753f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Can merge now, but has some conflicts. |
|
Gonna resolve. Thank you |
ttytm
force-pushed
the
checker/private-fields-errors
branch
from
ae2753f
to
b1a6aff
Compare
spytheman
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Merge AFTER 2024-05-31