Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDataTable): add missing disable-sort prop #19820

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

MajesticPotatoe
Copy link
Member

Description

fixes the missing disable-sort prop from v2
resolves #19197

Markup:

<template>
  <v-data-table
    disable-sort
    :sort-by="sortBy"
    :headers="headers"
    :items="items"
  />
  <v-data-table-virtual
    disable-sort
    :sort-by="sortBy"
    :headers="headers"
    :items="items"
  />
</template>

<script setup>
  const headers = [
    { key: 'id', title: 'ID' },
    { key: 'value', title: 'Value' },
  ]
  const items = [
    { id: 1, value: '1' },
    { id: 2, value: '2' },
    { id: 3, value: '3' },
    { id: 4, value: '4' },
  ]
  const sortBy = [{ key: 'value', order: 'desc' }]
</script>

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VDataTable VDatatable labels May 16, 2024
@MajesticPotatoe MajesticPotatoe self-assigned this May 16, 2024
@johnleider johnleider requested a review from KaelWD May 16, 2024 15:34
@KaelWD KaelWD merged commit 4a2de37 into master May 21, 2024
18 checks passed
@KaelWD KaelWD changed the title fix(VDataTable): readd missing disable-sort fix(VDataTable): add missing disable-sort prop May 21, 2024
@KaelWD KaelWD deleted the fix/disable-sort branch May 21, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Disable v-data-table sorting through a reimplementation of the disable-sort prop
3 participants