Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reader info support for UHFReader86 #3

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DylanDonkersgoed
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 15, 2020

Codecov Report

Merging #3 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   85.28%   85.33%   +0.04%     
==========================================
  Files           8        8              
  Lines         299      300       +1     
==========================================
+ Hits          255      256       +1     
  Misses         44       44
Impacted Files Coverage Δ
chafon_rfid/base.py 93.44% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6584a3b...0cbdae1. Read the comment docs.

@wabson
Copy link
Owner

wabson commented Mar 16, 2020

Thanks for the PR! I've not tested before with the CF-MU904 but looks like a nice bit of hardware so have ordered one to try out, along with the interface board.

In the meantime it would be great to add these changes to the library, just one thing I'm not sure of, could you explain what the uhfreader18.py file is for?

@DylanDonkersgoed
Copy link
Author

Don't mind that, still working on this. I copied the wrong file to the wrong place. I've added the proper uhfreader86.py file but it doesn't do too much at the moment. I added it as a stub to extend as necessary. Plus it was bugging me that I had to import the uhfreader288m stuff for a non-uhfreader288m reader.

I'm planning to build out my app a little more and expand the PR as needed. It will be doing more than just the inventory command - probably stop it beeping at least, maybe adjust some other configuration, maybe write some data (haven't decided whether I want to write data to the tags or keep a separate database of what corresponds to the IDs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants