-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get URL #682
base: master
Are you sure you want to change the base?
Get URL #682
Conversation
Can make this cross-platform
Are you sure this should be allowed? |
We're not going to merge anything that doesn't support all platforms. However, this is a good start for Linux and Windows. |
Code adjusted for changes in master.
Sorry it took me so long to take a proper look at this. I've added a few safety checks, macOS implementation and C API. As we didn't have any existing functions in the C API that return strings of unknown length, I wasn't quite sure what would be the best way to do so. I ended up going with an approach where the library by default dynamically allocates the memory needed and then returning it to the caller, with a way for the caller to choose how to allocate the string. I initially thought about I remember testing this PR a while back and found that we can't always expect |
Another simple pull request for another simple cross-platform API. Not implemented for MacOs because I don't have one. Stub only for EdgeHtml since we are discussing removing it.
std::string get_url()
returns the current URL.