Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore hidden files when uploading add-on #6417

Conversation

bunnybot
Copy link

@bunnybot bunnybot commented Mar 23, 2024

NordfrieseMirrored from Codeberg
Created on Sat Mar 23 14:11:46 CET 2024 by Benedikt Straub (Nordfriese)


Type of change
Enhancement

Issue(s) closed
Fixes #6326 / https://www.widelands.org/forum/topic/5930

New behavior
Any file or directory whose name starts with a '.' is skipped when uploading an add-on. In particular this will skip .git, .gitignore, .bzr, .bzrignore and similar.

Possible regressions
Add-ons uploading

Additional context
This was requested so it is easier for add-on authors to maintain their add-on with a local version control system.

@bunnybot bunnybot added this to the v1.3 milestone Mar 23, 2024
@bunnybot bunnybot self-assigned this Mar 23, 2024
@bunnybot
Copy link
Author

Assigned to Nordfriese

@bunnybot bunnybot added enhancement New feature or request addon Problems and requests related to add-ons labels Mar 23, 2024
@bunnybot bunnybot added the ci:success CI checks succeeded label Apr 2, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels Apr 11, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels Apr 22, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 1, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 4, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 17, 2024
@bunnybot bunnybot added the ci:success CI checks succeeded label May 20, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 20, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 23, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 31, 2024
Copy link
Author

@bunnybot bunnybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matthiaklMirrored from Codeberg
On Sat Jun 01 11:28:30 CEST 2024, matthiakl approved this pull request:

Simple and clear.

@bunnybot bunnybot added the review:approve The pull request has been approved. label Jun 1, 2024
@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels Jun 1, 2024
@bunnybot
Copy link
Author

bunnybot commented Jun 1, 2024

NordfrieseMirrored from Codeberg
On Sat Jun 01 13:32:19 CEST 2024, Benedikt Straub (Nordfriese) wrote:


Thanks for the review :)

<@>bunnybot merge

@bunnybot bunnybot closed this Jun 1, 2024
@bunnybot bunnybot deleted the mirror/Nordfriese/widelands/addon-upload-no-hidden-files branch June 1, 2024 11:37
bunnybot pushed a commit that referenced this pull request Jun 1, 2024
Co-authored-by: Benedikt Straub <nordfriese@noreply.codeberg.org>
Co-committed-by: Benedikt Straub <nordfriese@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon Problems and requests related to add-ons ci:success CI checks succeeded enhancement New feature or request review:approve The pull request has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-ons: Prevent uploading of specific files
2 participants