Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications Refresh (Phase 2) #20697

Open
wants to merge 153 commits into
base: trunk
Choose a base branch
from
Open

Notifications Refresh (Phase 2) #20697

wants to merge 153 commits into from
+3,832 −3,639

Conversation

antonis
Copy link
Member

@antonis antonis commented Apr 23, 2024

Subtasks

Notifications List

Comment Moderation

Milestones

Likes

Other

To Test:

Each issue listed above should be tested individually

Regression Notes

  1. Potential unintended areas of impact

    • N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A

  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@antonis antonis added Notifications Jetpack App Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Apr 23, 2024
@antonis antonis added this to the Future milestone Apr 23, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 23, 2024 •
edited

1 Error
🚫 This PR is tagged with Do Not Merge label(s).
5 Warnings
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class NoteBlockTextClickListener is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class BlockType is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class MilestoneNoteBlock is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024 •
edited

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20697-987d1f7
Commit987d1f7
Direct Downloadjetpack-prototype-build-pr20697-987d1f7.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024 •
edited

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20697-987d1f7
Commit987d1f7
Direct Downloadwordpress-prototype-build-pr20697-987d1f7.apk
Note: Google Login is not supported on these builds.

Jarvis Lin and others added 16 commits April 23, 2024 16:14
Extract dimens for the UI of header
8d8ee41
Merge branch 'feature/notifications_refresh_p2' into issue/Likes-Deta…
be7c455 
…ils-Header

# Conflicts:
#	WordPress/src/main/res/values/dimens.xml
Remove useless code
0cf7157
Update the UI of list item
92bd9e0
Update the item attrs
e6fc53c
Merge branch 'issue/Likes-Details-List' into issue/Likes-Details-Header
13dc9cf 
# Conflicts:
#	WordPress/src/main/java/org/wordpress/android/ui/engagement/EngagedPeopleAdapter.kt
Handle the CTA of Share a post
2156320
Handle the click for the Share CTA
972847d
Extract the string of button
ef2723d
Fix a lint issue
cbdf847
Extract the background color for light/dark themes
a127468
@jarvislin
Merge pull request #20700 from wordpress-mobile/issue/Likes-Details-H…
28557c1 
…eader

Update the UI of header and list in Likes Details
Merge branch 'feature/notifications_refresh_p2' into issue/Likes-Deta…
60b4e5a 
…ils-Share
Extract a color
d561f91
Fix a unit test
53819d1
Merge branch 'trunk' into feature/notifications_refresh_p2
6ec8b39
Jarvis Lin and others added 27 commits May 30, 2024 15:47
Fix lint issues
b71b440
Extracts NoteBlockTextClickListener
14346e8
Add tests
e60a6ab
Move milestone related functionality to the MilestoneDetailFragment
65d86dd
Creates a separate NoteBlock for milestones
cdb2796
Removes confetti animation
cd2e2ed
Fixes note text
e71e080
Removes confetti animation resource
50dc92f
Adds NonNull annotation
0b495ec
@jarvislin
Merge pull request #20916 from wordpress-mobile/issue/comment-details…
4f00ccc 
…-approve-moderation

Comment details approve moderation redesign
Pass note_id as bundle argument
a86f365
Replace the deprecated onActivityCreated with onViewCreated
4ba97f4
Merge branch 'trunk' into feature/notifications_refresh_p2
e52ef49
Merge branch 'feature/notifications_refresh_p2' into task/20715-extra…
ffa464e 
…ct-milestone-fragment
Moves note retrieval in the background
b187f85
@jarvislin
Merge pull request #20809 from wordpress-mobile/task/20715-extract-mi…
9f6e573 
…lestone-fragment

[Notifications Refresh] 🤖 Milestone Details: Badge and Title
Handle the share action
5f9c0a5
Handle the click of changing status in the comment menu
9f6b69c
Fix lint issues
78a2b09
Merge pull request #20944 from wordpress-mobile/issue/Comment-Details…
5493500 
…-Menu-redesign

Comment details menu redesign
Merge branch 'trunk' into feature/notifications_refresh_p2
3f7e49f
Add the implementation of trash action
852282b
Fix the flow of dispatching moderation actions
d537c35
Handle spam action
1735251
Make some refactors
d0fa51a
Merge pull request #20952 from wordpress-mobile/issue/Comment-Details…
34a279c 
…-Trash-moderation-redesign

Comment details trash moderation redesign
Merge branch 'trunk' into feature/notifications_refresh_p2
987d1f7
@antonis antonis modified the milestones: Future, 25.2 Jun 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Jetpack App Notifications unit-tests-exemption
Projects
None yet
Milestone
25.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@antonis @dangermattic @wpmobilebot @jarvislin