Add DCR integration tests #18491

SachiniSiriwardene · 2023-12-07T09:27:32Z

No description provided.

…er_DCRTest_New

(cherry picked from commit 2bc0385)

(cherry picked from commit 644168e)

(cherry picked from commit a446658)

(cherry picked from commit 1cdda47)

(cherry picked from commit 1da018c)

(cherry picked from commit 9907c3c)

(cherry picked from commit cffe18a)

(cherry picked from commit f4e163c)

(cherry picked from commit 569b399)

(cherry picked from commit eb249c0)

(cherry picked from commit d22d6bf)

(cherry picked from commit 95871e0)

jenkins-is-staging · 2023-12-08T08:05:20Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7138883250

jenkins-is-staging · 2023-12-08T09:26:26Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7138883250
Status: success

jenkins-is-staging

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7138883250

Thumimku · 2023-12-12T03:55:49Z

...test/java/org/wso2/identity/integration/test/oauth2/dcrm/api/FAPIDCRValidationsTestCase.java

@@ -0,0 +1,191 @@
+/*
+ * Copyright (c) 2023, WSO2 LLC. (https://www.wso2.com) All Rights Reserved.


Please check the license header, I think latest one should be

/** * Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com/). * * WSO2 LLC. licenses this file to you under the Apache License, * Version 2.0 (the "License"); you may not use this file except * in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */

Mail: License Header for WSO2 code

Thumimku · 2023-12-12T04:00:38Z

...ith-oidc/4.1.4.1-dcr/src/test/java/org/wso2/identity/scenarios/sso/test/dcr/DCRTestCase.java

@@ -98,7 +98,7 @@ private static Object[][] dcrConfigProvider() throws Exception {
                        getRegisterRequestJSON("request2.json"), getUpdateRequestJSON("request2.json"), ADMIN_USERNAME,
                        ADMIN_PASSWORD, SUPER_TENANT_DOMAIN
                }
-        };
+                };


is this change necessary?

Thumimku · 2023-12-12T04:03:18Z

...kend/src/test/java/org/wso2/identity/integration/test/oauth2/dcrm/api/OAuthDCRMTestCase.java

@@ -121,8 +118,8 @@ public void testCreateServiceProviderRequest() throws IOException {
    @Test(alwaysRun = true, groups = "wso2.is", priority = 2, description =
            "Create a service provider with already registered client name")
    public void testCreateServiceProviderRequestWithExistingClientName() throws IOException {
-        HttpPost request = new HttpPost(getPath());
-        request.addHeader(HttpHeaders.AUTHORIZATION, getAuthzHeader());
+        HttpPost request = new HttpPost(DCRUtils.getPath(tenant));


Let's add a new line after method signature, please check other places too.

Thumimku · 2023-12-12T04:03:42Z

...kend/src/test/java/org/wso2/identity/integration/test/oauth2/dcrm/api/OAuthDCRMTestCase.java

@@ -74,18 +74,15 @@ public OAuthDCRMTestCase(TestUserMode userMode) throws Exception {
    public static Object[][] dcrmConfigProvider() {
        return new Object[][]{{TestUserMode.SUPER_TENANT_ADMIN}, {TestUserMode.TENANT_ADMIN}};
    }
-


Let's keep this seperator

Thumimku · 2023-12-12T04:06:30Z

...-backend/src/test/java/org/wso2/identity/integration/test/oauth2/dcrm/api/util/DCRUtils.java

+    }
+    public static String getAuthzHeader(String username, String password) {
+
+        return "Basic " + Base64.encodeBase64String((username + ":" + password).getBytes()).trim();


Let's use a constant
ref:

product-is/modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/utils/OAuth2Constant.java

Line 92 in dfab6bb

public static final String BASIC_HEADER = "Basic";

Thumimku · 2023-12-12T04:11:40Z

...-backend/src/test/java/org/wso2/identity/integration/test/oauth2/dcrm/api/util/DCRUtils.java

+        request.addHeader(HttpHeaders.CONTENT_TYPE, OAuthDCRMConstants.CONTENT_TYPE);
+    }
+
+    public static String getPath(String tenant) {


can we reuse following Util method?

product-is/modules/integration/tests-common/integration-test-utils/src/main/java/org/wso2/identity/integration/common/utils/ISIntegrationTest.java

Line 159 in ab7c8ef

public String getTenantQualifiedURL(String endpointURL, String tenantDomain) {

…er_DCRTest_New

jenkins-is-staging · 2024-01-02T04:11:17Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7382144042

jenkins-is-staging · 2024-01-02T10:06:26Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7382144042
Status: cancelled

jenkins-is-staging · 2024-01-02T10:07:06Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7384506520

jenkins-is-staging · 2024-01-02T15:17:49Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7384506520
Status: cancelled

jenkins-is-staging · 2024-03-20T06:38:56Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8354783697

…er_DCRTest_New

Thumimku · 2024-03-20T08:01:46Z

...-backend/src/test/java/org/wso2/identity/integration/test/oauth2/dcrm/api/util/DCRUtils.java

@@ -0,0 +1,94 @@
+/*
+ * Copyright (c) 2023, WSO2 LLC. (https://www.wso2.com) All Rights Reserved.


jenkins-is-staging · 2024-03-20T12:39:12Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8354783697
Status: cancelled

jenkins-is-staging · 2024-03-21T08:55:23Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8371957298

jenkins-is-staging · 2024-03-21T14:55:47Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8371957298
Status: cancelled

CLAassistant · 2024-04-02T03:30:11Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jenkins-is-staging · 2024-04-02T03:31:47Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8517037519

jenkins-is-staging · 2024-04-02T05:08:33Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8517037519
Status: failure

jenkins-is-staging · 2024-04-03T04:10:09Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8533096870

jenkins-is-staging · 2024-04-03T05:55:25Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8533096870
Status: failure

…er_DCRTest_New

jenkins-is-staging · 2024-04-03T06:24:47Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8534200921

jenkins-is-staging · 2024-04-03T07:57:13Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8534200921
Status: failure

…er_DCRTest_New

SachiniSiriwardene added 23 commits October 11, 2023 09:19

add test case for persisting newly added DCR attributes

c7cb2e3

change test case priority

685d9ad

Merge branch 'master' of https://github.com/wso2/product-is

ddae1d9

Merge branch 'master' of https://github.com/wso2/product-is

eba231d

refactor tests

ea7c445

refactor tests

ca0088c

add update test case

eb36ea4

refactored code

a4dba8f

Merge branch 'master' of https://github.com/wso2/product-is into mast…

4e95b8d

…er_DCRTest_New

add fapi validations for dcr tests

63497ce

(cherry picked from commit 2bc0385)

add eof lines

dffd497

(cherry picked from commit 644168e)

refactor code

1ebcbb0

(cherry picked from commit a446658)

add fapi dcr validation tests to a separate class

61dfc21

(cherry picked from commit 1cdda47)

add config changes

cc18af5

(cherry picked from commit 1da018c)

address pr comments

4b54440

(cherry picked from commit 9907c3c)

update dcr tests

9e06af6

(cherry picked from commit cffe18a)

update dcr tests

cfcb0d5

(cherry picked from commit f4e163c)

address pr comments

9eb55f3

(cherry picked from commit 569b399)

change error message

6bc1d76

(cherry picked from commit eb249c0)

change application name to be common

eedca72

(cherry picked from commit d22d6bf)

fix test failures

faf21c9

(cherry picked from commit 95871e0)

change application name for error scenarios

cd98f8d

send tls_client_certificate_bound_access_tokens in dcr requests

527e1e4

jenkins-is-staging approved these changes Dec 8, 2023

View reviewed changes

Thumimku reviewed Dec 12, 2023

View reviewed changes

SachiniSiriwardene added 3 commits December 22, 2023 08:35

Merge branch 'master' of https://github.com/wso2/product-is into mast…

4f48eed

…er_DCRTest_New

address pr comments

e1567be

Merge branch 'master' of https://github.com/wso2/product-is into mast…

facd12a

…er_DCRTest_New

address pr comments

d0f6e26

SachiniSiriwardene added 2 commits March 20, 2024 12:10

change year in license header

8eab0d7

Merge branch 'master' of https://github.com/wso2/product-is into mast…

1d55269

…er_DCRTest_New

Thumimku reviewed Mar 20, 2024

View reviewed changes

change year in license header

4be99dc

fix failing tests

fe0b64d

Merge branch 'master' of https://github.com/wso2/product-is into mast…

7b214e1

…er_DCRTest_New

Merge branch 'master' of https://github.com/wso2/product-is into mast…

a7bf6d8

…er_DCRTest_New

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DCR integration tests #18491

Add DCR integration tests #18491

SachiniSiriwardene commented Dec 7, 2023

jenkins-is-staging commented Dec 8, 2023

jenkins-is-staging commented Dec 8, 2023

jenkins-is-staging left a comment

Thumimku Dec 12, 2023

Thumimku Dec 12, 2023

SachiniSiriwardene Jan 1, 2024

Thumimku Dec 12, 2023

SachiniSiriwardene Jan 1, 2024

Thumimku Dec 12, 2023

SachiniSiriwardene Jan 1, 2024

Thumimku Dec 12, 2023

SachiniSiriwardene Jan 1, 2024

Thumimku Dec 12, 2023

SachiniSiriwardene Jan 1, 2024

Thumimku Dec 12, 2023

SachiniSiriwardene Jan 1, 2024

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Mar 20, 2024

Thumimku Mar 20, 2024

SachiniSiriwardene Mar 20, 2024

jenkins-is-staging commented Mar 20, 2024

jenkins-is-staging commented Mar 21, 2024

jenkins-is-staging commented Mar 21, 2024

CLAassistant commented Apr 2, 2024

jenkins-is-staging commented Apr 2, 2024

jenkins-is-staging commented Apr 2, 2024

jenkins-is-staging commented Apr 3, 2024

jenkins-is-staging commented Apr 3, 2024

jenkins-is-staging commented Apr 3, 2024

jenkins-is-staging commented Apr 3, 2024

		@@ -0,0 +1,191 @@
		/*
		* Copyright (c) 2023, WSO2 LLC. (https://www.wso2.com) All Rights Reserved.

		@@ -0,0 +1,94 @@
		/*
		* Copyright (c) 2023, WSO2 LLC. (https://www.wso2.com) All Rights Reserved.

Add DCR integration tests #18491

Are you sure you want to change the base?

Add DCR integration tests #18491

Conversation

SachiniSiriwardene commented Dec 7, 2023

jenkins-is-staging commented Dec 8, 2023

jenkins-is-staging commented Dec 8, 2023

jenkins-is-staging left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Jan 2, 2024

jenkins-is-staging commented Mar 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jenkins-is-staging commented Mar 20, 2024

jenkins-is-staging commented Mar 21, 2024

jenkins-is-staging commented Mar 21, 2024

CLAassistant commented Apr 2, 2024

jenkins-is-staging commented Apr 2, 2024

jenkins-is-staging commented Apr 2, 2024

jenkins-is-staging commented Apr 3, 2024

jenkins-is-staging commented Apr 3, 2024

jenkins-is-staging commented Apr 3, 2024

jenkins-is-staging commented Apr 3, 2024