Change version to 3.2.6 and first backports #24544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rerun bakefile and autoconf.
Check wxXRC_NO_RELOADING out of the loop to avoid looping over all XRC files. See wxWidgets#24536. (cherry picked from commit ef0e3f8)
To have a proper centering with respect to the slider's line, the size of the slider in the dimension perpendicular to the slider's line has to be an even number. Therefore,when determining the best size, the size is adjusted to an even number when ticks are shown. See wxWidgets#24532, wxWidgets#24537. (cherry picked from commit a4a334e)
The label and value could become different when an attempt to set a value out of slider range was made. Make sure that the label always corresponds to the actual value. See wxWidgets#24539, wxWidgets#24540. (cherry picked from commit ca2a336)
Some locales use format specifiers not supported (yet) by wxDateTime::Parse() and while the best fix is to add support for them, as it has been already done for %F (see wxWidgets#24173) and will be done for "%-" (see wxWidgets#24533) soon, it still seems wise to handle the locales for which it still might happen, now or in the future, more gracefully by falling back to ISO 8601 date format if the locale format can't be used because we can't parse it. Note that an alternative approach could consist in using the locale format for formatting the dates and falling back to ISO 8601 only for parsing them, but it would arguably be confusing to the user if the program expected input in a format different from what it uses for displaying the dates, so prefer just using the same format for both, if we can't do otherwise. (cherry picked from commit 8e66698)
This is not really used when parsing, but we still need to support the GNU extensions to the strftime() formatting specifiers used to change padding, as they can (and do, at least in the case of "%-d" and "%-m") occur in the locale descriptions and so can be used when parsing dates using the current locale format. See wxWidgets#24533. (cherry picked from commit 2cc3a38)
Fixes invisible wxHeaderCtrl sort indicator with some themes, such as the Ubuntu 18.04 default "Ambiance" (cherry picked from commit 90bae20)
…ents Fixes wxSYS_COLOUR_INFOBK on Ubuntu 18.04 default theme, for example (cherry picked from commit ffd7e7d)
They were mixed up when computing the item size, yielding wrong results when their values were different. Fix this and also use m_[hv]gap directly for consistency with the rest of the code in this file instead of using Get[HV]Gap() accessors that were not used anywhere else. See wxWidgets#24550. (cherry picked from commit b4c3bcd)
See wxWidgets#24551 (cherry picked from commit b70f101)
Set the position regardless of whether default centering is in effect. See wxWidgets#24552. (cherry picked from commit 6795178)
This can be more convenient to use than public functions and it's just better to support all Windows versions in this function too. (cherry picked from commit 456449b)
For some reason, testing for Windows Server 2019 was missing there. See wxWidgets#24598. (cherry picked from commit c7c6485)
Stop using Node 16-based version as it's deprecated now.
For some reason the test has started consistently failing there, so disable it for now. See wxWidgets#24594. (cherry picked from commit 79ddb0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.