Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android-Gui: Allow setting the DecorView to transparent color #25171

Closed
wants to merge 1 commit into from

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented May 9, 2024

Sony TVs have a long standing firmware bug. Allow a user to configure the background color to workaround this.

Usage:

<advancedsettings>
  <gui>
   <transparentguilayout>true</transparentguilayout>
 </gui>
</advancedsettings>

@fritsch
Copy link
Member Author

fritsch commented May 9, 2024

First draf for #25166 - I only wrote the code. I did neither compile nor runtime test it. Also did not verify the thingy we want to alter is already there. Just that we have discussion starting point.

@quietvoid @joseluismarti and @Kristijan1001

This is a one time setting. While it uses quietvoid's code from back then - it is not dolby vision depending but applies globally as the Sony People have GUI issues in general. Could be combined with other regressions more dynamically.

Sony TVs have a long standing firmware bug. Allow a user to configure
the background color to workaround this.

Usage:
<advancedsettings>
  <gui>
   <transparentguilayout>true</transparentguilayout>
 </gui>
</advancedsettings>
@Ragnaroeko
Copy link

Sony TVs have a long standing firmware bug. Allow a user to configure the background color to workaround this.

Usage:

<advancedsettings>
  <gui>
   <transparentguilayout>true</transparentguilayout>
 </gui>
</advancedsettings>

I have an Android TV SONY KD-55XE9005 that is about 6/7 years old and since the Kodi update 21 I have gray transparent bars in films where the black bars were removed when playing, it looks terrible. Do you have any instructions for me on how I can remove this so that the bars are black again? Thanks for your help!

Best regards

@quietvoid
Copy link
Contributor

quietvoid commented Jun 2, 2024

Hi @fritsch, this is working for me on FireTV stick: quietvoid@5d6b162

The DecorView in the past was transparent. Now I'm not sure what it is by default but the color is not set by Kodi anymore.
But the VideoLayout view is the one that needs to be changed by the advanced setting, at least on my device.

I'm not sure what the view hierarchy is, but hopefully changing only VideoLayout is good enough.

@fritsch
Copy link
Member Author

fritsch commented Jun 2, 2024

@quietvoid Cool! Feel free to replace this PR. Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Platform: Android Type: Fix non-breaking change which fixes an issue v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants