Add playlist FileItem classify #25200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notspiff
added
Type: Improvement
notspiff
force-pushed
the
add_playlist_fileitem_classify
branch
from
498fc83
to
452f666
Compare
CrystalP
reviewed
May 12, 2024
| @@ -517,7 +517,10 @@ bool CGUIWindowMusicBase::OnContextButton(int itemNumber, CONTEXT_BUTTON button) | |||
|
|
|||
| case CONTEXT_BUTTON_EDIT_SMART_PLAYLIST: | |||
| { | |||
| std::string playlist = item->IsSmartPlayList() ? item->GetPath() : m_vecItems->GetPath(); // save path as activatewindow will destroy our items | |||
| std::string playlist = | |||
There was a problem hiding this comment.
might as well throw in a const.
CrystalP
reviewed
May 12, 2024
| @@ -940,7 +940,10 @@ bool CGUIWindowVideoBase::OnContextButton(int itemNumber, CONTEXT_BUTTON button) | |||
| return true; | |||
| case CONTEXT_BUTTON_EDIT_SMART_PLAYLIST: | |||
| { | |||
| std::string playlist = m_vecItems->Get(itemNumber)->IsSmartPlayList() ? m_vecItems->Get(itemNumber)->GetPath() : m_vecItems->GetPath(); // save path as activatewindow will destroy our items | |||
| std::string playlist = | |||
CrystalP
reviewed
May 12, 2024
Comment on lines
+26
to
+27
| if (item.HasProperty("library.smartplaylist") && | ||
| item.GetProperty("library.smartplaylist").asBoolean()) |
There was a problem hiding this comment.
item.GetProperty("library.smartplaylist").asBoolean(false)?
|
I probably didn't noticed in previous PR, the copyright years of the new files seem strange? I don't know the rules though, is that on purpose? |
jenkins4kodi
added
the
Rebase needed
|
@notspiff this needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move playlist fileitem classifiers to separate file
Motivation and context
Reduce CFileItem interface
How has this been tested?
Builds + I have added tests
What is the effect on users?
None
Types of change
Checklist: