Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL/GLES: split off GLES from GLTexture #25207

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

sarbes
Copy link
Member

@sarbes sarbes commented May 13, 2024

Description

This PR splits off the GLES part of GLTexture.

Motivation and context

No more ifdeffery (#25205).

How has this been tested?

GL and GLES compile and run fine.

What is the effect on users?

None.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@sarbes sarbes added Type: Improvement non-breaking change which improves existing functionality v22 "P" labels May 13, 2024
@sarbes sarbes added this to the "P" 22.0 Alpha 1 milestone May 13, 2024
@sarbes sarbes requested a review from lrusak May 13, 2024 10:53
xbmc/guilib/TextureGLES.cpp Outdated Show resolved Hide resolved
xbmc/guilib/TextureGLES.cpp Outdated Show resolved Hide resolved
xbmc/guilib/TextureGLES.h Outdated Show resolved Hide resolved
@sarbes
Copy link
Member Author

sarbes commented May 26, 2024

Yeah, sorry. I've had a cleaner version I did not commit.

I've also improved the truncation behavior for GLES 3.0.

@sarbes sarbes merged commit b36eb9a into xbmc:master Jun 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants