Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redirect with python substitution #5423

Merged
merged 15 commits into from
May 26, 2024
Merged

Fixed redirect with python substitution #5423

merged 15 commits into from
May 26, 2024

Conversation

anki-code
Copy link
Member

@anki-code anki-code commented May 16, 2024

Motivation

Closes #5420

Before

xonsh --no-rc
f = p'/tmp/file.tmp'
echo 'abc' > @(f)
# returns error: xonsh: ['/tmp/file.tmp']: unable to open file

After

xonsh --no-rc
f = p'/tmp/file.tmp'
echo 'abc' > @(f)
cat @(f)
# abc

For community

⬇️ Please click the 👍 reaction instead of leaving a +1 or 👍 comment

@anki-code anki-code requested a review from jnoortheen May 16, 2024 12:11
@anki-code anki-code marked this pull request as draft May 16, 2024 13:35
@anki-code anki-code marked this pull request as ready for review May 16, 2024 13:44
@anki-code
Copy link
Member Author

@jnoortheen it's ready to review, please take a look! Thanks!

@anki-code anki-code requested a review from gforsyth May 24, 2024 20:57
@anki-code
Copy link
Member Author

@jnoortheen what do you think?

@jnoortheen
Copy link
Member

this can better be done at parser level. But I am good with this for now.

@anki-code anki-code merged commit 14342b2 into main May 26, 2024
12 checks passed
@anki-code anki-code deleted the fix_redirect_to_subst branch May 27, 2024 20:37
@anki-code
Copy link
Member Author

It was regress - #5466 - we need to revert this PR after regress will be fixed.

@anki-code anki-code mentioned this pull request May 31, 2024
anki-code added a commit that referenced this pull request May 31, 2024
I'm going to revert #5423 because it was regress -
#5466 - and we need to fix parser
instead of resolver.

## For community
⬇️ **Please click the 👍 reaction instead of leaving a `+1` or 👍
comment**

---------

Co-authored-by: a <1@1.1>
anki-code added a commit that referenced this pull request Jun 2, 2024
This reverts commit c9046ab.
@anki-code anki-code mentioned this pull request Jun 2, 2024
anki-code added a commit that referenced this pull request Jun 2, 2024
Reverts #5468

Closes #5466

Related #5423

---------

Co-authored-by: a <1@1.1>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redirection: unable to open file
2 participants