Refreshing procs/specs.py
#5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anki-code
changed the title
SpecModifier and threadable and unthreadableSpecModifier and threadable and unthreadable aliases
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
anki-code
changed the title
SpecModifier and threadable and unthreadable aliasesSpecModifier and xth xunth aliases + refactoring code of _update_last_spec
anki-code
changed the title
SpecModifier and xth xunth aliases + refactoring code of _update_last_specSpecModifier and xth xunth aliases + splitting _update_last_spec into functions
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
anki-code
changed the title
SpecModifier and xth xunth aliases + splitting _update_last_spec into functionsSpecModifier and xth xunth aliases + cleaning procs/specs.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
# Conflicts: # xonsh/aliases.py
for more information, see https://pre-commit.ci
jnoortheen
reviewed
May 18, 2024
anki-code
changed the title
SpecModifier and xth xunth aliases + cleaning procs/specs.pySpecModifier, xth xunth aliases and cleaning procs/specs.py
anki-code
changed the title
SpecModifier, xth xunth aliases and cleaning procs/specs.pySpecModifier, xth xunth aliases and refreshing procs/specs.py
anki-code
changed the title
SpecModifier, xth xunth aliases and refreshing procs/specs.pyprocs/specs.py
|
@gforsyth @jnoortheen I splitted this PR into two:
Please review and merge. Thanks! |
jnoortheen
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR just clean the code in
procs/specs.pywithout changes the logic: group the code into functions. This is needed to the next feature PR #5443.For community
⬇️ Please click the 👍 reaction instead of leaving a
+1or 👍 comment