WITCHER: Add CAuroraSettings data structure and initialization #527
Conversation
|
Oh, neat, thanks! :) (I'm a bit swamped with a move at the moment, so replies might be spotty. Sorry about that.) However...I don't really want the original naming convention in xoreos' code. It clashes with our own naming conventions. Could you change that? A few other things:
|
|
Thanks for the comments, I have done those modifications. |
| @@ -424,6 +424,667 @@ class LuaBindings { | |||
| static int luaBor(lua_State *state); | |||
| }; | |||
|
|
|||
| struct CAuroraSettingsData { | |||
| uint32_t _staticTimeFlow; | |||
There was a problem hiding this comment.
Can you use uint32 instead of uint32_t, to be consistent with the rest of the codebase?
(Yes, doing that was a mistake on my part, back when I started xoreos, but now we're kinda stuck with it.)
| @@ -424,6 +424,667 @@ class LuaBindings { | |||
| static int luaBor(lua_State *state); | |||
| }; | |||
|
|
|||
| struct CAuroraSettingsData { | |||
There was a problem hiding this comment.
Just make it AuroraSettingsData, please.
| uint32_t _speedTreeRenderBillboards; | ||
| uint32_t _dumpLoadingTextures; | ||
|
|
||
| CAuroraSettingsData(); |
There was a problem hiding this comment.
This won't compile, since you add the constructor definiton in a later commit.
But also, can you do C++11-style inline initializations here instead? I.e.
float _attackLockDist { 6.0f };
| @@ -142,11 +142,17 @@ void LuaBindings::registerBindings() { | |||
| LuaScriptMan.endRegister(); | |||
| } | |||
|
|
|||
| CAuroraSettingsData g_auroraSettings; | |||
There was a problem hiding this comment.
Does this have to be a global global? Can it be a static within LuaBindings::luaGetAuroraSettings() instead?
|
Hi @rcxrdx, are you still interested in working on this? |
The CAuroraSettings data structure shared between C++/LUA is added from reversing the game in version 1.4.5.1304.
The fields have their original names (and thus original naming convention) to make the individual fields bindings easier.