Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ImageCrop): add image-crop component #12868

Closed
wants to merge 3 commits into from

Conversation

jczzq
Copy link
Contributor

@jczzq jczzq commented May 14, 2024

@jczzq jczzq closed this May 14, 2024
@jczzq jczzq reopened this May 14, 2024
@jczzq jczzq closed this May 14, 2024
@jczzq jczzq reopened this May 14, 2024
@chenjiahan
Copy link
Member

感谢你的贡献,对于这个组件,我倾向于不内置到 Vant 组件库中,它更适合作为一个独立的库来使用,原因如下:

  • Vant 设计规范中没有包含该组件,当前 PR 设计的组件样式与 Vant 其他组件的设计风格有比较明显的差异
  • 该组件采用了 Vue Options API,而 Vant 所有组件都采用 Composition API 实现

建议将该组件发布为独立的 npm 提供给社区使用~

@jczzq
Copy link
Contributor Author

jczzq commented May 22, 2024

好吧

@inottn inottn closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants