Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/HearThisAt] Improve _VALID_URL #9949

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

bohwaz
Copy link
Contributor

@bohwaz bohwaz commented May 17, 2024

Description of your pull request and other information

This updates the HearThis.at URL regexp to allow for private tracks, which contain a last part:

Private track URL: https://hearthis.at/tindalos/0001-tindalos-gnrique/eQd/
Public track URL: https://hearthis.at/moofi/dr-kreep

Closes #9755

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for a private track URL?

yt_dlp/extractor/hearthisat.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-bug Issue with a specific website pending-fixes PR has had changes requested labels May 18, 2024
@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels May 19, 2024
@seproDev seproDev changed the title Update hearthisat URL regexp to allow downloading of private tracks [ie/HearThisAt] Improve _VALID_URL May 19, 2024
@Grub4K Grub4K removed the pending-review PR needs a review label May 22, 2024
yt_dlp/extractor/hearthisat.py Outdated Show resolved Hide resolved
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev seproDev merged commit 5bbfdb7 into yt-dlp:master May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update valid url regexp for hearthis.at
4 participants