test: dac: esp32s2_devkitc bugfix #73015
Conversation
add dts and dac setting for tests/driver/dac/dac_api Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
|
looks like there is a cycling dependency on the two PRs #72802, do we need merge them to in PR? |
@hakehuang I think so. Would you update your with this change or you want us to update this? |
| &dac { | ||
| status = "okay"; | ||
| }; |
There was a problem hiding this comment.
Can we add this directly to the board file in order to avoid so many overlays here?
There was a problem hiding this comment.
this will case the dac is enabled by default for any application, which may increase your code size. but you can make decision.
There was a problem hiding this comment.
No, it is only compiled if enabled via Kconfig. I prefer enabling it in the board file (similar to most other boards).
I realized that some ESP32 boards do indeed use an overlay as well, but that should probably be fixed.
let me do this |
|
I cherry-pick the commit to my pr #72984, thanks @martinjaeger and @wmrsouza , you can close this PR once merged |
add dts and dac setting for tests/driver/dac/dac_api