Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): add new step to activate SMTP provider #7956

Merged
merged 6 commits into from
May 22, 2024

Conversation

doncicuto
Copy link
Contributor

Which Problems Are Solved

How the Problems Are Solved

  • When a new SMTP provider is added or updated, the wizard has a new step that allow us to activate or deactivate the provider configured in the previous step. The following video shows the new wizard:
activate_smtp_wizard.mp4

Additional Context

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 7:15am

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label May 15, 2024
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it @doncicuto 🚀

Just some minor change requests...

console/src/assets/i18n/bg.json Outdated Show resolved Hide resolved
@doncicuto
Copy link
Contributor Author

Sure @eliobischof, thanks for your review I'll prepare the changes ASAP

@eliobischof eliobischof enabled auto-merge (squash) May 21, 2024 07:31
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.75%. Comparing base (5b1160d) to head (6aa8099).

Files Patch % Lines
internal/api/grpc/admin/iam_settings_converter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7956      +/-   ##
==========================================
- Coverage   62.76%   62.75%   -0.01%     
==========================================
  Files        1341     1341              
  Lines      111028   111029       +1     
==========================================
- Hits        69682    69678       -4     
- Misses      37423    37426       +3     
- Partials     3923     3925       +2     
Flag Coverage Δ
core-integration-tests-postgres 62.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doncicuto can you have a look at the e2e tests, please?

auto-merge was automatically disabled May 22, 2024 07:07

Head branch was pushed to by a user without write access

@doncicuto
Copy link
Contributor Author

Sorry @eliobischof I totally missed the e2e tests, my bad 😳

@eliobischof eliobischof merged commit cca3421 into zitadel:main May 22, 2024
25 of 27 checks passed
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SMTP templates. Show activate provider as another optional step
3 participants