-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(login): ignore select_account in case there aren't any session to choose #7981
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for your contribution! 🎉Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7981 +/- ##
=======================================
Coverage ? 62.76%
=======================================
Files ? 1341
Lines ? 111033
Branches ? 0
=======================================
Hits ? 69691
Misses ? 37418
Partials ? 3924
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 2.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Which Problems Are Solved
When poviding
select_account
in an OIDC auth request, ZITADEL would always show the account selection page even if there aren't any user sessions to choose and the user would then need to click theOther User
button to be presented the login page.How the Problems Are Solved
This PR changes the behavior and ignores the
select_account
prompt in case there aren't any existing user sessions and will directly present the login page.Additional Changes
None
Additional Context
Closes #7213