Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): ignore select_account in case there aren't any session to choose #7981

Merged
merged 4 commits into from
May 21, 2024

Conversation

livio-a
Copy link
Member

@livio-a livio-a commented May 17, 2024

Which Problems Are Solved

When poviding select_account in an OIDC auth request, ZITADEL would always show the account selection page even if there aren't any user sessions to choose and the user would then need to click the Other User button to be presented the login page.

How the Problems Are Solved

This PR changes the behavior and ignores the select_account prompt in case there aren't any existing user sessions and will directly present the login page.

Additional Changes

None

Additional Context

Closes #7213

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 0:36am

Copy link

github-actions bot commented May 17, 2024

Thanks for your contribution! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d55aae5). Learn more about missing BASE report.

Current head 4e6b815 differs from pull request most recent head 69872d6

Please upload reports for the commit 69872d6 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7981   +/-   ##
=======================================
  Coverage        ?   62.76%           
=======================================
  Files           ?     1341           
  Lines           ?   111033           
  Branches        ?        0           
=======================================
  Hits            ?    69691           
  Misses          ?    37418           
  Partials        ?     3924           
Flag Coverage Δ
core-integration-tests-postgres 62.76% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livio-a livio-a requested a review from muhlemmer May 21, 2024 09:26
@livio-a livio-a enabled auto-merge (squash) May 21, 2024 09:27
@livio-a livio-a merged commit 07f91e4 into main May 21, 2024
25 checks passed
@livio-a livio-a deleted the prompt-select-single branch May 21, 2024 12:53
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prompt=select_account automatically go to "Other User" when there is no account to choose
2 participants