restore last window bounds #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariodian
commented
Jun 3, 2023
| @@ -52,7 +76,7 @@ const createTray = (window) => { | |||
| { | |||
| label: 'Show', | |||
| click: () => { | |||
| win.maximize(); | |||
| setWindowBounds(window); | |||
There was a problem hiding this comment.
I'm not sure what Tray() should be in MacOS because I see no menu with "Show" label anywhere. If anyone could test it on Windows and Linux it would be great.
mariodian
commented
Jun 3, 2023
| @@ -66,7 +90,7 @@ const createTray = (window) => { | |||
| ]); | |||
|
|
|||
| tray.on('click', () => { | |||
| win.maximize(); | |||
| setWindowBounds(window); | |||
There was a problem hiding this comment.
I'm not sure what Tray() should be in MacOS because I see no menu with "Show" label anywhere. If anyone could test it on Windows and Linux it would be great.
mariodian
force-pushed
the
save-window-size
branch
from
374a56c
to
b18db50
Compare
|
rebased |
mariodian
force-pushed
the
save-window-size
branch
from
b18db50
to
7e45b9a
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #323
Saves the last window size and position and restores it on the next run.
It uses
electron-storeto store the bounds in~/Application Support/better-chatpgt/config.json(for Mac, not sure where it saves in Linux and Windows)