new conversation: Show correct tooltip when dms are disabled.

[kennethnrk]

Earlier when dms were disabled, the new conversation button tooltip wasn't being updated, therefore a stale tooltip was being shown.

Earlier the data-conversation-type attribute of the new conversation button was being set to direct only if dms were enabled. As a result a stale tooltip was being shown when dms were disabled.
This commit updates the attribute to direct reagardless of dms being enabled or not.

Note

A user can always DM themselves or a bot, even when direct messages are disabled in an org — the reason why we don't disable the "Start new conversation" button. (#28412)

Fixes #29916.

Screenshots and screencaptures

336899046-5808aa3a-d1ea-4f41-b03f-3c5468cc144b.webm

[alya]

Since this PR hasn't been reviewed yet, please ping your buddy to take a look.

[kennethnrk]

@PieterCK Please review this PR.

[zulipbot]

ERROR: Label "buddy review" already exists and was thus not added to this pull request.

[PieterCK]

Hi Kenneth, nice work here. code LGTM, but left a suggestion.

Other than that, the PR description could probably be clearer if you add a clip of the new behavior though, so here's one I took when testing. Feel free to add it to the PR description!

Screencast.from.05-06-24.22.10.26.webm

Let me know if you have any questions 👍

---

Manually tested and found that the expected result described in #29916 has been achieved.
steps: disable DM > go to stream > show tool tip > go to DM > show tool tip

[kennethnrk]

Thanks @PieterCK, I'm not sure how to download and reupload your screen capture to the description, could you please help me. : )

[alya]

Thanks for the review, @PieterCK ! When the PR looks good to you, you can remove the "buddy review" label via Zulipbot.

@kennethnrk you can then add a "mentor review" label and ping your mentor.

[PieterCK]

@kennethnrk I think you can right-click on my clip, choose "Save Video As ..." and then it should download. I'm using Firefox though, do you have that functionality in your browser?

@zulipbot remove "buddy review"

[PieterCK]

Oh, wait. I think you want to add a commit description explaining the reasoning behind the change and why it fixes the issue and better than the current state. Probably something like:
"The previous logic assumes that .... This commit changes .... which improves ....."

For example, here's a good one from Tim! It's from one of your previous PR 👍
ba92cd8
@kennethnrk

[kennethnrk]

@kennethnrk I think you can right-click on my clip, choose "Save Video As ..." and then it should download. I'm using Firefox though, do you have that functionality in your browser?

I'm using Brave, when i clicked save video it was giving me a message media not available. It worked finally. 👍

[kennethnrk]

Thanks @PieterCK, I've made the changes.

[kennethnrk]

@zulipbot add "maintainer review", "mentor review"

@arpit551 Please review this whenever you're available.

[kennethnrk]

@zulipbot add "mentor review"

[timabbott]

It looks like you added the details that belong in the commit message in the PR description. Since it's commits, not PRs, that get merged, you want 3f4bd50 to have the context for posterity.

[timabbott]

Earlier when dms were disabled, the new conversation button tooltip wasn't being updated, therefore a stale tooltip was being shown.

The previous logic didn't update the new conversation tooltip when dms were disabled. This commit updates the tooltip regardless of dms being disabled.

And then I want to note that this text doesn't answer the key question as to how the old logic failed to do this update; it's not obvious to me from skimming.

[kennethnrk]

It looks like you added the details that belong in the commit message in the PR description. Since it's commits, not PRs, that get merged, you want 3f4bd50 to have the context for posterity.

I'm not sure how I overlooked that. I have updated the commit message.