Validator dashboard QA

[thesan]

⚠️ Dependencies

The QA should start only once #4742 and Joystream/joystream#4933 get merged and dev is merged into validator branch one last time.

Context

Designs

Testing environment 👉 https://dao-git-validators-joystream.vercel.app

Scope

Dashboard itself

This should be tested at least partially on Mainnet. There has been some back and forth on how to calculate some of the values and it's important to make sure that non what is displayed is misleading to nominators. Also this page should work well in mobile:

1. Dashboard statistic headers statistic accuracy:
   
2. Dashboard list item accuracy + interaction with the filters/ordering/pagination, etc..
   
3. Validator cards layout + data accuracy:
   
4. The "Nominate" links:
   

Binding validator accounts to memberships

It might be easier to test this on a playground. In that case Atlas dev should be fine: https://dao-git-validators-joystream.vercel.app/#/settings?network-config=https://atlas-dev.joystream.org/network/config.json

Regardless you'll need to create validator accounts on the network used for the tests.

1. Binding a/multiple validators to a new membership.
2. Binding a/multiple validators to an existing membership.
3. Verify and unverifiy validator accounts via the CLI (add CLI command verifyValidator joystream#4933) and check their statuses on the dashboard.

[ivanturlakov]

Dashboard

Tested on https://dao-git-validators-joystream.vercel.app/ Mainnet

✅ Dashboard statistic headers statistic accuracy

⚠️ Dashboard list item accuracy + interaction with the filters/ordering/pagination, etc..

• The average APR calculation looks incorrect. If you sort by descending - the first 14 validators' ARPs will be 5%-2%, the rest 1%-0%
• Let us make social media icons as hyperlinks to related resources
• Search validation msg (desktop & mobile)

⚠️ Validator cards layout + data accuracy

• Let us make social media icons as hyperlinks to related resources
• Customize the width of the mobile version if possible

• Nominate modal - typo “NoRminate”

[kdembler]

No tooltip texts:

Unclear "Last" in rewards section. I guess it's last era?

If "All" is selected in filters, there's no text in the select:

Validation message shouldn't appear as I'm typing, only once I submit with Enter:

CleanShot.2024-01-27.at.16.49.40.mp4

When I search for something, and then remove it and confirm with Enter, the search isn't cancelled (I press Enter at the end):

CleanShot.2024-01-27.at.16.50.29.mp4

[eshark9312]

@kdembler @ivanturlakov
I fixed most of the issues, please check with this url.
https://dao-9pwmfuy5v-joystream.vercel.app/

[eshark9312]

@ivanturlakov
I have not fixed the apr calculation yet. (It looks correct to me.)
Could you check again and let me know what the APRs should look?
Total staking is about 120M (almost of the staking comes from nominators), the last month reward is about 1M then the annual reward is 12M.
When the commission is 10%, then the reward for the nominators is 1.2M so the average apr is about 1%.

[ivanturlakov]

Retested on https://dao-9pwmfuy5v-joystream.vercel.app/ mainnet
https://dao-git-fork-eshark9312-validator-dashboard-qa-joystream.vercel.app/#/validators mainnet

✅ tooltips
✅ filters/search
✅ Validator card

@eshark9312 thanks!

Pls add a minor fix for Social links
Change Telegram link to "https://t.me/userName"

@kdembler what do you think about the formula for calculating expected Nominator APR? I am a Nominator and have checked my actual average APR and it ranges from 5 to 7% while the expected APR shows 1%

[thesan]

@ivanturlakov thank you for the quick feedback. But the correct environment is: https://dao-git-fork-eshark9312-validator-dashboard-qa-joystream.vercel.app/ (not https://dao-9pwmfuy5v-joystream.vercel.app).

On the APR thanks a lot for checking, it's very important to make sure we are not underestimating those. I'll look some more into it this week. @kdembler @eshark9312 please have look too.

[eshark9312]

@ivanturlakov
You are right. The APR for nominators should be calculated by the following formula:
Yearly Reward * (1 - Commission) / Stake
cc @kdembler @thesan

[ivanturlakov]

Tested on https://37.27.43.23.nip.io/pioneer/#/settings?network-config=https://37.27.43.23.nip.io/network/config.json

Binding a/multiple validators to a new membership

Trying to add two validators when creating a new user

⚠️ Strange behavior during validation - when adding the first validator, the Create button is inactive.

But if you add an empty field for the second validator, the button is activated.

⚠️ I added the addresses of 2 validators but only one was bound (I suspect the first one on the list). The transaction was also performed for only one validator.

Binding a/multiple validators to an existing membership

⚠️ Strange behavior during validation - when adding the first validator, the Save button is inactive.

But if you add an empty field for the second validator, the button is activated.

⚠️ I added the addresses of 2 validators but only one was bound (I suspect the first one on the list). The transaction was also performed for only one validator.

⚠️ I tried to bind the second validator separately (the first one is already displayed in the profile), but when clicking Save the transaction is not initiated, but immediately shows the success window

[eshark9312]

@ivanturlakov
After you select the validator account(or paste the address), you have to click add button, if not it is not included to the validator accounts to be bound to your membership.
And the last issue:

I tried to bind the second validator separately (the first one is already displayed in the profile), but when clicking Save the transaction is not initiated, but immediately shows the success window

I fixed it, in this case the save button should be disabled until click the add button.
#4767

[ivanturlakov]

After you select the validator account(or paste the address), you have to click add button, if not it is not included to the validator accounts to be bound to your membership.

This is not obvious logic. Validator address fields should work like a normal form field - if there is an address there, then it is valid. The add button should only be responsible for adding a new validator address field. If we leave everything as it is, we need to add an explanation (after entering the validator, press the plus button). @kdembler @thesan what you think?

[ivanturlakov]

Verify and unverifiy validator accounts via the CLI

Tested on https://37.27.43.23.nip.io/pioneer/#/settings?network-config=https://37.27.43.23.nip.io/network/config.json

Works as expected
✅ Verify tester-6 yarn joystream-cli working-groups:verifyValidator --group=membership 1
✅ unVerify tester-6 yarn joystream-cli working-groups:verifyValidator --group=membership 1
✅ Verify tester-5 yarn joystream-cli working-groups:verifyValidator --group=membership 0