-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address create/update validator membership QA issues #4767
Address create/update validator membership QA issues #4767
Conversation
eshark9312
commented
Feb 8, 2024
•
edited by thesan
edited by thesan
- Validator dashboard QA #4743
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good so far but I agree with @ivanturlakov that the current UX is un-intuitive. TBH it append to me several times to select a validator and wonder for a moment why the button was disabled (even though I know how the design is supposed to work). And if even @ivanturlakov got confused it means that most validator will be confused too. So I think we should change the UX so it works kind of like the application form:
By default there would be one select, under the select a "Add Validator account" button which would add other selects above itself. Something like this:
(oc the remove field icon can remain a X)
WDYT ?
1a6e4b0
to
33869a3
Compare
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!