Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address create/update validator membership QA issues #4767

Merged

Conversation

eshark9312
Copy link
Contributor

@eshark9312 eshark9312 commented Feb 8, 2024

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Feb 13, 2024 1:59am
pioneer-2 ✅ Ready (Inspect) Visit Preview Feb 13, 2024 1:59am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Feb 13, 2024 1:59am

Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good so far but I agree with @ivanturlakov that the current UX is un-intuitive. TBH it append to me several times to select a validator and wonder for a moment why the button was disabled (even though I know how the design is supposed to work). And if even @ivanturlakov got confused it means that most validator will be confused too. So I think we should change the UX so it works kind of like the application form:
image

By default there would be one select, under the select a "Add Validator account" button which would add other selects above itself. Something like this:
image
(oc the remove field icon can remain a X)

WDYT ?

Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thesan thesan merged commit 703fc42 into Joystream:validators Feb 13, 2024
7 checks passed
@ivanturlakov
Copy link

Tested on https://dao-92au0ua0u-joystream.vercel.app/#/settings?network-config=https://37.27.43.23.nip.io/network/config.json

Thanks for the update 👍 This version looks more intuitive and user friendly
Screenshot 2024-02-14 at 15 04 33

✅ Binding 2 validators to a new membership
✅ Binding 2 validators to an existing membership
✅ Add +1 validator to an existing membership

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants