Add support for musig() key expressions #230
Conversation
bigspider
force-pushed
the
musig
branch
4 times, most recently
from
ef7dd97
to
420aa97
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #230 +/- ##
===========================================
- Coverage 84.85% 84.78% -0.07%
===========================================
Files 17 17
Lines 2192 2235 +43
===========================================
+ Hits 1860 1895 +35
- Misses 332 340 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bigspider
force-pushed
the
musig
branch
2 times, most recently
from
23b3795
to
4ca8540
Compare
…icies to more general key expressions
…ed some comments. Generalizing to key expressions containing musig() makes it necessary to distinguish the key expressions in the wallet policy from the actual key placeholders that are just indexes to the list of key informations (@num in the descriptor template), whereas the two concepts were often not clearly separated in the code base. Renaming to "key expressions" makes the distinction more clear.
…on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
…ues in sign_psbt in the python client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uint32_t addr_index_step = input->in_out.address_index; | ||
|
|
||
| uint8_t bip32_tweak_1[32]; | ||
| uint8_t bip32_tweak_2[32]; |
Check notice
Code scanning / CodeQL
Unused local variable Note
| // int pk_offset = is_tap ? 1 : 0; | ||
| // if (memcmp(pubkey.compressed_pubkey + pk_offset, bip32_derivation_pubkey, key_len) != 0) | ||
| // { | ||
| // return 0; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
|
Closes: #208