Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for musig() key expressions #230

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from
Draft

Add support for musig() key expressions #230

wants to merge 21 commits into from

Commits on May 13, 2024

  1. Added parsing for musig(); generalized key placeholders in wallet pol… 

    …icies to more general key expressions
    @bigspider
    bigspider committed May 13, 2024
    Configuration menu
    Copy the full SHA
    29ab971 View commit details
    Browse the repository at this point in the history

  2. Rename "key placeholder" with "key expression" where appropriate; add… 

    …ed some comments.

Generalizing to key expressions containing musig() makes it necessary to distinguish
the key expressions in the wallet policy from the actual key placeholders that are
just indexes to the list of key informations (@num in the descriptor template),
whereas the two concepts were often not clearly separated in the code base.

Renaming to "key expressions" makes the distinction more clear.
    @bigspider
    bigspider committed May 13, 2024
    Configuration menu
    Copy the full SHA
    60827f5 View commit details
    Browse the repository at this point in the history

  3. Fix typo in error message

    @bigspider
    bigspider committed May 13, 2024
    Configuration menu
    Copy the full SHA
    479bc8d View commit details
    Browse the repository at this point in the history

  4. Refactored policy_node_keyexpr_t to explicitly label which of the uni… 

    …on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
    @bigspider
    bigspider committed May 13, 2024
    Configuration menu
    Copy the full SHA
    242c60f View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Add PSBT constants related to MuSig2; deleted unused constant

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    23013d1 View commit details
    Browse the repository at this point in the history

  2. Moved secp256k1 constants to a separate module

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9ba0e96 View commit details
    Browse the repository at this point in the history

  3. Added address generation tests for musig

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f91cb19 View commit details
    Browse the repository at this point in the history

  4. Made crypto_tr_lift_x and crypto_tr_tagged_hash functions public

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7241d2b View commit details
    Browse the repository at this point in the history

  5. Musig key aggregation and address generation

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    458b5d9 View commit details
    Browse the repository at this point in the history

  6. Compute aggregate xpub for musig() in descriptors in the python clien… 

    …t library
    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4a7586c View commit details
    Browse the repository at this point in the history

  7. Add musig2 fields to PSBT class

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    979e361 View commit details
    Browse the repository at this point in the history

  8. Added python standalone implementation of MuSig2 signing, and tests

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0c74fec View commit details
    Browse the repository at this point in the history

  9. Add 'tweak' output parameter to bip32_CKDpub; exposed BIP341 constants

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    681f112 View commit details
    Browse the repository at this point in the history

  10. Add parsing of Musig2 pubnonces and partial signatures as yielded val… 

    …ues in sign_psbt in the python client
    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5ed718f View commit details
    Browse the repository at this point in the history

  11. MuSig2 signing, rounds 1 and 2

    @bigspider
    bigspider committed May 28, 2024
    Configuration menu
    Copy the full SHA
    79855b9 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Update musig() specs, and fix psbt processing 

     - musig() now sorts the keys, as per the BIP draft
 - correctly compute fingerprint for musig() aggregate key
 - added both the aggregate and the internal key in keyexpr_info_t struct
 - fixed psbt parsing logic to detect change/addr_index for musig
 - updated musig tests
    @bigspider
    bigspider committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e69770c View commit details
    Browse the repository at this point in the history

  2. Fix psbt-level musig signing session logic

    @bigspider
    bigspider committed May 31, 2024
    Configuration menu
    Copy the full SHA
    bf138ed View commit details
    Browse the repository at this point in the history

  3. Modularize and extract the musig session handling from sign_psbt.c

    @bigspider
    bigspider committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7691676 View commit details
    Browse the repository at this point in the history

  4. Persistent storage for musig psbt signing sessions

    @bigspider
    bigspider committed May 31, 2024
    Configuration menu
    Copy the full SHA
    46fb3f2 View commit details
    Browse the repository at this point in the history

  5. Add ragger navigation to musig sign_psbt tests

    @bigspider
    bigspider committed May 31, 2024
    Configuration menu
    Copy the full SHA
    1052f85 View commit details
    Browse the repository at this point in the history

  6. Update sanity checks for musig key expressions

    @bigspider
    bigspider committed May 31, 2024
    Configuration menu
    Copy the full SHA
    63415a1 View commit details
    Browse the repository at this point in the history