Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUPPORT]: Remove .unit usage from account.unit #6604

Closed
wants to merge 13 commits into from
Closed

[SUPPORT]: Remove .unit usage from account.unit #6604

wants to merge 13 commits into from

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Apr 3, 2024 •
edited by gre

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Remove usage of account.unit or getAccountUnit and replaced it with a more centralised way in Settings for each currency

📝 Description

Move "unit" field out of Account and move the related settings from Account settings back to the Currency settings (LLD only currently, LLM will be next)

Screenshot 2024-04-03 at 14 45 04
Screen.Recording.2024-04-03.at.14.41.45.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 3:28pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 3:28pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 3:28pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 3:28pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 3:28pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 3, 2024
@mcayuelas-ledger mcayuelas-ledger marked this pull request as ready for review April 4, 2024 13:52
@mcayuelas-ledger mcayuelas-ledger requested review from a team as code owners April 4, 2024 13:52
@mcayuelas-ledger mcayuelas-ledger force-pushed the support/move-unit branch 2 times, most recently from bc6d903 to 1bc9808 Compare April 17, 2024 07:45
@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner April 25, 2024 13:26
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Apr 25, 2024
@mcayuelas-ledger
Revert "fix e2e"
b8f4b56 
This reverts commit 39b4161.
@live-github-bot live-github-bot bot removed the mobile Has changes in LLM label Apr 25, 2024
This was referenced Apr 26, 2024
Closed
Merged
@gre
Copy link
Contributor

gre commented May 2, 2024

=> #6796

@gre gre closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre gre left review comments

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcayuelas-ledger @gre