chore: decoupled {unit, starred, name} fields away from Account model

[gre]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.
• Impact of the changes:
  • see respective PRs for documented impacts

📝 Description

This PR mashups many iterations on our Account model rework. some of these PRs were incrementally reviewed, so we now hope for a final review on this PR 🙏 👍 NB: on this big mashup PR: it is easier to refactor the Account model in one batch and also with this one squashed commit, especially how it is complex to rebase with develop when changes are made there. see respective PRs for extended documentations:

• Drop Account#name, Account#starred and LLD to use Currency Settings' instead of Account#unit #6761
• chore: LLM currency unit settings + drop all remaining usage of Account#unit #6791
• introduce wallet store, decoupling of account user's data (name, starred,..) from the account's blockchain data #6534
• [SUPPORT]: Remove .unit usage from account.unit #6604

user impact

For users, this PR impacts one thing: the unit settings (e.g. seeing amounts in satoshi instead of BTC) was moved to the currency settings.

per the PR comment below, this PR will however not address yet the usage of the currency unit in the "currency level features" like the account distributions or the assets screens.

That said, we removed the inconsistency behaviour of our app that was allowing to have different unit on different accounts 😆

the other user benefits is that, since we moved the unit from account unit to global currency unit, the global UX will be improved, notably this will fixed bugs related to unit lagging in the UI to be changed until the app is restarted (fixes https://ledgerhq.atlassian.net/browse/LIVE-12288 & https://ledgerhq.atlassian.net/browse/LIVE-11956 )

mini guide for developers

The other changes brought by this PR are only impacting the developers. The whole point was to completely remove all user's off chain config away from "Account", making this Account type entirely restorable from the blockchain data.

before this PR:

after this PR: we have a true decoupling of the data (between on chain and off chain data) while keeping the same AccountRaw serialized data

therefore, for developers, the impact is that you no longer have unit, starred, name fields directly available in Account. Instead you will get it on the end projects (LLD, LLM) with some accessors (selectors or hooks).
You will be able to easily switch from one approach to another with these:

- account.unit
- getAccountUnit(account)
+ useAccountUnit(account)
+ useMaybeAccountUnit(maybeAccount)
+ accountUnitSelector(state, account)
# ^ when we can't afford hooks, we use the redux store to lense the account's unit
+ account.currency.units[0]
# ^ if and only if we can afford to just fallback to the default's unit

- account.name
- getAccountName(account)
+ useAccountName(account)
+ useMaybeAccountName(maybeAccount)
+ accountNameWithDefaultSelector(walletState, account) 
# ^ when we can't afford hooks, we use the walletState store to lense the account's name
+ getDefaultAccountName(account)
# ^ if and only if we can afford to just fallback to the default and initial account's name

- account.starred
+ accountStarredSelector(state, { accountId: account.id })
# (nb: very few usage of this one, it is ok to only have a basic selector)

---

ℹ️ 🪓 on the recent Account model and account management simplifications, see also:

• chore: sunset implicitMigration #6585
• chore: sunset unused ChildAccount type #6524
• chore: remove unused Account#freshAddresses field #6523
• chore: remove unused Account#endpointConfig field #6521

❓ Context

• JIRA or GitHub link:
  • https://ledgerhq.atlassian.net/browse/LIVE-11770
  • https://ledgerhq.atlassian.net/browse/LIVE-11767
  • https://ledgerhq.atlassian.net/browse/LIVE-11768
  • https://ledgerhq.atlassian.net/browse/LIVE-11769

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview		May 6, 2024 1:04pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview		May 6, 2024 1:04pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		May 6, 2024 1:04pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		May 6, 2024 1:04pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview		May 6, 2024 1:04pm

[sprohaszka-ledger]

I have still some files to review (all the coin families at least), but right now 2 things:

• coin-framework must not have any live-wallet logic inside. It's purpose is UI-agnostic.
• AccountRaw should reflect what Account is, not what Account+AccountUserData. We need to isolate backward compatibility issue in dedicated function, not in DataModel, as much as possible.

[gre]

notes after testing LLM:

• account distribution don't take unit into account
  • i see BTC under the pie chart where my accounts are in sats
  • currency asset screen don't take unit into account (e.g. the Bitcoin assets screen show the total balance in BTC where the account are correctly shown in sats)
  • same for the crypto home screen

now this seems to be purely intentional to not take the account unit into account, because before it wasn't even shared at the currency level, so we will not address this in this rework I think, but i'll ask product team.

apps/ledger-live-mobile/src/screens/WalletCentricAsset/AssetRow.tsx

[sprohaszka-ledger]

👍 for Coin Integ team ownership.

[Justkant]

LGTM tested mobile and desktop locally too

[ofreyssinet-ledger]

reviewed mainly the device experience team scope and it's all good 👍

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ TypeError: Cannot read properties of null (reading 'contract') fromHydrateValidator(libs/ledger-live-common/sr... View Issue
• ‼️ TypeError: t.toFixed is not a function toOperationRaw(libs/coin-framework/src/serializ... View Issue
• ‼️ TypeError: Cannot convert object to primitive value mergeOps(libs/coin-framework/src/bridge/jsHelpers) View Issue
• ‼️ Error: currency with id "ethereum_goerli" not found getCryptoCurrencyById(libs/ledgerjs/packages/cr... View Issue
• ‼️ RangeError: Invalid time value toOperationRaw(libs/coin-framework/src/serializ... View Issue

_{Did you find this useful? React with a 👍 or 👎}

[gre]

can't be related