Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: LLM currency unit settings + drop all remaining usage of Account#unit #6791

Closed
wants to merge 3 commits into from
Closed

chore: LLM currency unit settings + drop all remaining usage of Account#unit #6791

wants to merge 3 commits into from

Conversation

gre
Copy link
Contributor

@gre gre commented Apr 30, 2024 •
edited

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • account unit in LLM

📝 Description

Replace usage of Account#unit in LLM to a new per currency settings.

all remaining usages of account.unit in live-common and cli where a mistake and we always wanted to do getAccountCurrency(account).units[0] for them, notably they are for two usecases:

  • formatting (cli / logs / bot / tests): we can afford to use the primary unit
  • device transaction verification step: in this case, the device uses the primary unit so we must uses units[0] and not account.unit.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 8:28am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 8:28am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 8:28am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 8:28am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 8:28am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs cli labels Apr 30, 2024
@gre gre force-pushed the support/account-name-lldunit branch from 74717c4 to e9c8c82 Compare May 2, 2024 08:00
@gre gre mentioned this pull request May 2, 2024
Closed
3 tasks
@live-github-bot
Copy link
Contributor

live-github-bot bot commented May 2, 2024 •
edited

Desktop Bundle Checks

Comparing 6928ae3 against e9c8c82.

✅ Previous issues have all been fixed.

Mobile Bundle Checks

Comparing 6928ae3 against e9c8c82.

@gre gre mentioned this pull request May 2, 2024
Merged
3 tasks
@gre gre force-pushed the support/account-name-all-unit branch from bcb037c to 6928ae3 Compare May 2, 2024 08:23
@gre
Copy link
Contributor Author

gre commented May 2, 2024

the PR is moving to #6796

@gre gre closed this May 2, 2024
@gre gre deleted the support/account-name-all-unit branch May 30, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gre gre

Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gre @mcayuelas-ledger